Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: content/browser/android/download_controller.cc

Issue 10696173: Revert "Revert 146000 - Split out ContentViewCore from ContentView for embedders." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase number deux Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/download_controller.cc
diff --git a/content/browser/android/download_controller.cc b/content/browser/android/download_controller.cc
index ccd3996b0f95b20babaa0103ca096dd975b05121..ca6b90a1ccf741af3edcce7d7bcf4886fcae1de5 100644
--- a/content/browser/android/download_controller.cc
+++ b/content/browser/android/download_controller.cc
@@ -9,6 +9,7 @@
#include "base/bind.h"
#include "base/logging.h"
#include "base/memory/scoped_ptr.h"
+#include "content/browser/android/content_view_core_impl.h"
#include "content/browser/download/download_item_impl.h"
#include "content/browser/renderer_host/render_process_host_impl.h"
#include "content/browser/renderer_host/render_view_host_delegate.h"
@@ -218,7 +219,7 @@ void DownloadController::OnPostDownloadStarted(
// Register for updates to the DownloadItem.
download_item->AddObserver(this);
- jobject view = GetContentViewFromWebContents(web_contents);
+ jobject view = GetContentViewCoreFromWebContents(web_contents);
if(!view) {
// The view went away. Can't proceed.
return;
@@ -245,14 +246,14 @@ void DownloadController::OnDownloadUpdated(DownloadItem* item) {
ScopedJavaLocalRef<jstring> jpath =
ConvertUTF8ToJavaString(env, item->GetFullPath().value());
- jobject view = GetContentViewFromWebContents(item->GetWebContents());
- if(!view) {
+ jobject view_core = GetContentViewCoreFromWebContents(item->GetWebContents());
+ if (!view_core) {
// We can get NULL WebContents from the DownloadItem.
return;
}
Java_DownloadController_onHttpPostDownloadCompleted(env,
- GetJavaObject()->Controller(env).obj(), view, jurl.obj(),
+ GetJavaObject()->Controller(env).obj(), view_core, jurl.obj(),
jcontent_disposition.obj(), jmime_type.obj(), jpath.obj(),
item->GetReceivedBytes(), true);
}
@@ -274,10 +275,10 @@ jobject DownloadController::GetContentView(int render_process_id,
if (!web_contents)
return NULL;
- return GetContentViewFromWebContents(web_contents);
+ return GetContentViewCoreFromWebContents(web_contents);
}
-jobject DownloadController::GetContentViewFromWebContents(
+jobject DownloadController::GetContentViewCoreFromWebContents(
WebContents* web_contents) {
NOTIMPLEMENTED();
return NULL;
« no previous file with comments | « content/browser/android/download_controller.h ('k') | content/browser/renderer_host/render_widget_host_view_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698