Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1622)

Unified Diff: content/public/browser/android/content_view.h

Issue 10696173: Revert "Revert 146000 - Split out ContentViewCore from ContentView for embedders." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase number deux Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/android/content_view.h
diff --git a/content/public/browser/android/content_view.h b/content/public/browser/android/content_view.h
deleted file mode 100644
index 95d1fbfaa44cb993ebf20448672ee2758216383d..0000000000000000000000000000000000000000
--- a/content/public/browser/android/content_view.h
+++ /dev/null
@@ -1,50 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CONTENT_PUBLIC_BROWSER_CONTENT_VIEW_H_
-#define CONTENT_PUBLIC_BROWSER_CONTENT_VIEW_H_
-
-#include <jni.h>
-
-class GURL;
-
-namespace content {
-
-class WebContents;
-
-// Native side of the ContentView.java, the primary FrameLayout of
-// Chromium on Android. This is a public interface used by native
-// code outside of the content module.
-//
-// TODO(jrg): this is a shell. Upstream the rest.
-//
-// TODO(jrg): downstream, this class derives from
-// base::SupportsWeakPtr<ContentView>. Issues raised in
-// http://codereview.chromium.org/10536066/ make us want to rethink
-// ownership issues.
-// FOR THE MERGE (downstream), re-add derivation from
-// base::SupportsWeakPtr<ContentView> to keep everything else working
-// until this issue is resolved.
-// http://b/6666045
-class ContentView {
- public:
- virtual void Destroy(JNIEnv* env, jobject obj) = 0;
-
- static ContentView* Create(JNIEnv* env, jobject obj,
- WebContents* web_contents);
- static ContentView* GetNativeContentView(JNIEnv* env, jobject obj);
-
- // --------------------------------------------------------------------------
- // Public methods that call to Java via JNI
- // --------------------------------------------------------------------------
-
- virtual void StartContentIntent(const GURL& content_url) = 0;
-
- protected:
- virtual ~ContentView() {};
-};
-
-}; // namespace content
-
-#endif // CONTENT_PUBLIC_BROWSER_CONTENT_VIEW_H_

Powered by Google App Engine
This is Rietveld 408576698