Issue 3752. Support for @override annotations (as structured doc comments)

Issue 3752. Support for @override annotations (as structured doc comments)
http://code.google.com/p/dart/issues/detail?id=3752

Now we always record comments and bind them to nodes.
We record DartMetadata for each DartDeclaration with flags for @deprecated and @override.
In this CL we analyze @override and report error if method does not actually override anything.


R=brianwilkerson@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=9129

[Brian Wilkerson, 2012-06-25 14:24:38]

LGTM overall, but unless you're confident that we want most of these changes
even if we get language-defined metadata fairly soon it might be better to hold
off on checking this in to see how quickly metadata gets addressed.

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/DartCompilerMainContext.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/DartCompilerMainContext.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/parser/DartParser.java:219: //  public
DartParser(ParserContext ctx) {
Do we need this commented out code, or can we delete it?

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/parser/DartScannerParserContext.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/parser/DartScannerParserContext.java:1:
// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java:126:
INVALID_OVERRIDE_METADATA("Method marked with @override, but does not override
any superclass element"),
This should be a warning, not an error.

I think we need some way to recognize warnings that are not part of the spec. so
that we can ignore them if the user doesn't want to see them. I might be missing
it, but I don't see that here. (Fixing in a separate CL is preferred.)

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:2689: if
(overridden.isEmpty() && node.getMetadata().isOverride()) {
Is there any demand for the inverse (warning for an overriding method that is
not marked as @override)?

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
File
compiler/javatests/com/google/dart/compiler/common/LibrarySourceFileTest.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/common/LibrarySourceFileTest.java:1:
// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/AbstractParserTest.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/AbstractParserTest.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/CPParserTest.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/CPParserTest.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/CommentTest.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/CommentTest.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/DartParserRunner.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/DartParserRunner.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/DietParserTest.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/DietParserTest.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/LibraryParserTest.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/LibraryParserTest.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/ParserEventsTest.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/ParserEventsTest.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTestCase.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTestCase.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

[scheglov, 2012-06-26 19:46:34]

Most of these changes are:
1. call single Parser constructor;
2. always create and bind comments;

I.e. something not bad by itself.

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/DartCompilerMainContext.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/DartCompilerMainContext.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
On 2012/06/25 14:24:38, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/parser/DartParser.java:219: //  public
DartParser(ParserContext ctx) {
On 2012/06/25 14:24:38, Brian Wilkerson wrote:
> Do we need this commented out code, or can we delete it?

Done.

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/parser/DartScannerParserContext.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/parser/DartScannerParserContext.java:1:
// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
On 2012/06/25 14:24:38, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java:126:
INVALID_OVERRIDE_METADATA("Method marked with @override, but does not override
any superclass element"),
On 2012/06/25 14:24:38, Brian Wilkerson wrote:
> This should be a warning, not an error.
> 
> I think we need some way to recognize warnings that are not part of the spec.
so
> that we can ignore them if the user doesn't want to see them. I might be
missing
> it, but I don't see that here. (Fixing in a separate CL is preferred.)

I saw that ErrorSeverity.INFO was added for this.

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:2689: if
(overridden.isEmpty() && node.getMetadata().isOverride()) {
On 2012/06/25 14:24:38, Brian Wilkerson wrote:
> Is there any demand for the inverse (warning for an overriding method that is
> not marked as @override)?

This would add a lot of warnings into existing projects.
I'm not ready to addd this without explicit request.

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
File
compiler/javatests/com/google/dart/compiler/common/LibrarySourceFileTest.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/common/LibrarySourceFileTest.java:1:
// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
On 2012/06/25 14:24:38, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/AbstractParserTest.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/AbstractParserTest.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
On 2012/06/25 14:24:38, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/CPParserTest.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/CPParserTest.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
On 2012/06/25 14:24:38, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/CommentTest.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/CommentTest.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
On 2012/06/25 14:24:38, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/DartParserRunner.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/DartParserRunner.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
On 2012/06/25 14:24:38, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/DietParserTest.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/DietParserTest.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
On 2012/06/25 14:24:38, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/LibraryParserTest.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/LibraryParserTest.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
On 2012/06/25 14:24:38, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/parser/ParserEventsTest.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/ParserEventsTest.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
On 2012/06/25 14:24:38, Brian Wilkerson wrote:
> nit: copyright year

Done.

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTestCase.java
(right):

https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTestCase.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
On 2012/06/25 14:24:38, Brian Wilkerson wrote:
> nit: copyright year

Done.

[scheglov, 2012-06-26 19:54:15]

On 2012/06/25 14:24:38, Brian Wilkerson wrote:


>
https://chromiumcodereview.appspot.com/10661022/diff/1/compiler/java/com/goog...
> compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java:126:
> INVALID_OVERRIDE_METADATA("Method marked with @override, but does not override
> any superclass element"),
> This should be a warning, not an error.

  Hm...
  Actually issue requests error for invalid @override.