Issue 3752. Support for @override annotations (as structured doc comments)

compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 package com.google.dart.compiler.type;
 
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Joiner;
 import com.google.common.base.Objects;
 import com.google.common.collect.ArrayListMultimap;
@@ skipping 2667 matching lines @@
         }
         return null;
       }
 
       @Override
       public Void visitMethodDefinition(DartMethodDefinition node) {
         MethodElement method = node.getElement();
         String name = method.getName();
         if (superMembers != null && !method.isConstructor()) {
           Collection<Element> overridden = superMembers.removeAll(name);
+          // Check for invalid @override metadata.
+          if (overridden.isEmpty() && node.getMetadata().isOverride()) {

[Brian Wilkerson, 2012/06/25 14:24:38]

Is there any demand for the inverse (warning for an overriding method that is
not marked as @override)?

[scheglov, 2012/06/26 19:46:34]

This would add a lot of warnings into existing projects.
I'm not ready to addd this without explicit request.

+            typeError(node.getName(), ResolverErrorCode.INVALID_OVERRIDE_METADATA);
+          }
+          // Check that override is valid.
           for (Element element : overridden) {
             if (canOverride(node.getName(), method.getModifiers(), element)) {
               switch (element.getKind()) {
                 case METHOD:
                   checkOverride(node.getName(), method, element);
                   break;
 
                 case FIELD:
                   typeError(node.getName(), TypeErrorCode.SUPERTYPE_HAS_FIELD, element.getName(),
                             element.getEnclosingElement().getName());
@@ skipping 119 matching lines @@
         for (VariableElement v : parameters) {
           if (v.isNamed()) {
             named.add(v);
           }
         }
         return named;
       }
     }
   }
 }