editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java - Issue 10661022: Issue 3752. Support for @override annotations (as structured doc comments)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java

Issue 10661022: Issue 3752. Support for @override annotations (as structured doc comments) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTestCase.java ('K') | « editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java ('k') | editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionParser.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java

diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java

index a8776a8f033c59d5ecb2389f30c03a6a14cda8d6..dbe72c23ec7bf0186da47a35928c48a92ed1e68e 100644

--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java

+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionEngine.java

@@ -54,8 +54,6 @@ import com.google.dart.compiler.ast.DartVariableStatement;

import com.google.dart.compiler.ast.DartWhileStatement;

import com.google.dart.compiler.ast.LibraryUnit;

import com.google.dart.compiler.common.SourceInfo;

-import com.google.dart.compiler.parser.DartScannerParserContext;

-import com.google.dart.compiler.parser.ParserContext;

import com.google.dart.compiler.resolver.ClassElement;

import com.google.dart.compiler.resolver.ClassNodeElement;

import com.google.dart.compiler.resolver.ConstructorElement;

@@ -1462,7 +1460,6 @@ public class CompletionEngine {

CompletionMetrics metrics = requestor.getMetrics();

DartCompilerListener listener = DartCompilerListener.EMPTY;

- ParserContext ctx = new DartScannerParserContext(sourceFile, source, listener);

prefixes = new HashSet<String>();

if (currentCompilationUnit != null) {

DartImport[] imports = currentCompilationUnit.getLibrary().getImports();

@@ -1473,7 +1470,7 @@ public class CompletionEngine {

}

- CompletionParser parser = new CompletionParser(ctx, prefixes);

+ CompletionParser parser = new CompletionParser(sourceFile, source, prefixes, listener, null);

parser.setCompletionPosition(completionPosition);

parsedUnit = DartCompilerUtilities.secureParseUnit(parser, sourceFile);