Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 10635011: Add glBindUniformLocationCHROMIUM (Closed)

Created:
8 years, 6 months ago by greggman
Modified:
8 years, 6 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Add glBindUniformLocationCHROMIUM TEST=unit tests BUG=132844 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144070

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1045 lines, -899 lines) Patch
A gpu/GLES2/extensions/CHROMIUM/CHROMIUM_bind_uniform_location.txt View 1 chunk +131 lines, -0 lines 0 comments Download
D gpu/GLES2/extensions/CHROMIUM/CHROMIUM_consistent_uniform_locations.txt View 1 chunk +0 lines, -88 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 3 chunks +8 lines, -11 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 1 chunk +3 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 chunk +30 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 3 chunks +11 lines, -91 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +2 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 2 chunks +0 lines, -128 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 chunk +147 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 chunk +69 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_unittest.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 5 chunks +83 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 30 chunks +30 lines, -60 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 25 chunks +73 lines, -24 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 73 chunks +83 lines, -159 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 4 chunks +17 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/program_manager.h View 7 chunks +27 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 21 chunks +189 lines, -46 lines 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 17 chunks +64 lines, -39 lines 0 comments Download
M gpu/command_buffer/service/test_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 4 chunks +26 lines, -37 lines 0 comments Download
A + gpu/command_buffer/tests/gl_bind_uniform_location_unittest.cc View 4 chunks +29 lines, -29 lines 0 comments Download
D gpu/command_buffer/tests/gl_consistent_uniform_locations_unittest.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M gpu/gpu_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M third_party/khronos/GLES2/gl2ext.h View 1 chunk +6 lines, -12 lines 0 comments Download
M third_party/khronos/README.chromium View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
greggman
Hey Al, PTAL
8 years, 6 months ago (2012-06-21 22:56:14 UTC) #1
apatrick_chromium
8 years, 6 months ago (2012-06-21 23:17:56 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698