Issue 10584040: Merge 142914 - Remove NTP4 intro bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10584040: Merge 142914 - Remove NTP4 intro bubble (Closed)

Created:
8 years, 6 months ago by guohui

Modified:
8 years, 6 months ago

Reviewers:
sky, guohui, Evan Stade

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/branches/1180/src/

Visibility:
Public.

Merge 142914 - Remove NTP4 intro bubble BUG=132330 TEST=Launch chrome and open NTP page, verify that intro bubble is never shown. Review URL: https://chromiumcodereview.appspot.com/10556048 TBR=guohui@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143236

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -110 lines)			Patch
M	chrome/browser/prefs/browser_prefs.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.js	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_page_handler.h	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_page_handler.cc	View	5 chunks	+0 lines, -59 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/ntp_resource_cache.cc	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/common/chrome_notification_types.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/pref_names.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

LGTM