Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: chrome/browser/resources/ntp4/new_tab.js

Issue 10584040: Merge 142914 - Remove NTP4 intro bubble (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1180/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp4/new_tab.js
===================================================================
--- chrome/browser/resources/ntp4/new_tab.js (revision 143232)
+++ chrome/browser/resources/ntp4/new_tab.js (working copy)
@@ -181,27 +181,6 @@
// The anchor node won't be updated until updateLogin is called so don't
// show the bubble yet.
shouldShowLoginBubble = true;
- } else if (loadTimeData.valueExists('ntp4_intro_message')) {
- infoBubble = new cr.ui.Bubble;
- infoBubble.anchorNode = newTabView.mostVisitedPage.navigationDot;
- infoBubble.setArrowLocation(cr.ui.ArrowLocation.BOTTOM_START);
- infoBubble.handleCloseEvent = function() {
- this.hide();
- chrome.send('introMessageDismissed');
- };
-
- var bubbleContent = $('ntp4-intro-bubble-contents');
- infoBubble.content = bubbleContent;
-
- bubbleContent.querySelector('div > div').innerHTML =
- loadTimeData.getString('ntp4_intro_message');
-
- var learnMoreLink = bubbleContent.querySelector('a');
- learnMoreLink.href = loadTimeData.getString('ntp4_intro_url');
- learnMoreLink.onclick = infoBubble.hide.bind(infoBubble);
-
- infoBubble.show();
- chrome.send('introMessageSeen');
}
var loginContainer = getRequiredElement('login-container');
« no previous file with comments | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698