Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 10556048: Remove NTP4 intro bubble (Closed)

Created:
8 years, 6 months ago by guohui
Modified:
8 years, 6 months ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Remove NTP4 intro bubble BUG=132330 TEST=Launch chrome and open NTP page, verify that intro bubble is never shown. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -110 lines) Patch
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.js View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_handler.h View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_page_handler.cc View 5 chunks +0 lines, -59 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/common/chrome_notification_types.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
guohui
This Cl removes all code related to NTP4 intro bubble. @achuith, I am not sure ...
8 years, 6 months ago (2012-06-18 18:09:42 UTC) #1
Evan Stade
lgtm
8 years, 6 months ago (2012-06-18 19:14:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/10556048/1
8 years, 6 months ago (2012-06-18 19:35:00 UTC) #3
commit-bot: I haz the power
Presubmit check for 10556048-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-18 19:35:13 UTC) #4
achuithb
No dependency on this bubble. lgtm.
8 years, 6 months ago (2012-06-18 20:00:02 UTC) #5
sky
LGTM
8 years, 6 months ago (2012-06-18 21:21:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/10556048/1
8 years, 6 months ago (2012-06-18 23:15:05 UTC) #7
commit-bot: I haz the power
Try job failure for 10556048-1 (retry) on win_rel for step "chrome_frame_net_tests". It's a second try, ...
8 years, 6 months ago (2012-06-19 01:21:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/10556048/1
8 years, 6 months ago (2012-06-19 01:23:59 UTC) #9
commit-bot: I haz the power
8 years, 6 months ago (2012-06-19 04:34:59 UTC) #10
Try job failure for 10556048-1 (retry) on win_rel for step
"chrome_frame_net_tests".
It's a second try, previously, step "chrome_frame_net_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698