Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 10579028: Revert 142427 - Cleaning Up Extensions When Local Content Removed (Closed)

Created:
8 years, 6 months ago by karen
Modified:
8 years, 6 months ago
Reviewers:
Devlin
CC:
chromium-reviews, ncarter (slow), mihaip-chromium-reviews_chromium.org, akalin, Raghu Simha, Aaron Boodman, tim (not reviewing)
Visibility:
Public.

Description

Revert 142427 - Cleaning Up Extensions When Local Content Removed This fixes an issue where removing an extension's local content, e.g. deleting the user-data-dir/Default/Extensions/<id> directory, would result in a broken extension. Chrome will now uninstall/remove any extensions where the path to the extension cannot be resolved. BUG=31910 TEST=ExtensionServiceTest.CleanupInternalExtensionsMissingLocalContent; ExtensionServiceTest.CleanupUnpackedExtensionsMissingLocalContent; test by hand by loading an extension, deleting the local directory, and restarting chrome Review URL: https://chromiumcodereview.appspot.com/10541126 TBR=rdevlin.cronin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -430 lines) Patch
D chrome/browser/extensions/extension_garbage_collector.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/extensions/extension_garbage_collector.cc View 1 chunk +0 lines, -192 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 4 chunks +19 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 5 chunks +5 lines, -129 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_helper.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_file_util.h View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 1 chunk +63 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_file_util_unittest.cc View 1 chunk +57 lines, -0 lines 0 comments Download
D chrome/test/data/extensions/garbage_collection/Extensions/fdoajpacpdeapbmhbblepcnilfkpmkff/1.0_0/manifest.json View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/garbage_collection/Extensions/fdoajpacpdeapbmhbblepcnilfkpmkff/1.1_0/manifest.json View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/garbage_collection/Preferences View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years, 6 months ago (2012-06-19 20:57:27 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698