Revert 142427 - Cleaning Up Extensions When Local Content Removed

chrome/common/extensions/extension_file_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension_file_util.h"
 
 #include "base/file_util.h"
 #include "base/json/json_string_value_serializer.h"
 #include "base/path_service.h"
 #include "base/scoped_temp_dir.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
 #include "grit/generated_resources.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/l10n/l10n_util.h"
 
 using extensions::Extension;
 
 namespace keys = extension_manifest_keys;
 
+#if defined(OS_WIN)
+// http://crbug.com/106381
+#define InstallUninstallGarbageCollect DISABLED_InstallUninstallGarbageCollect
+#endif
+TEST(ExtensionFileUtil, InstallUninstallGarbageCollect) {
+  ScopedTempDir temp;
+  ASSERT_TRUE(temp.CreateUniqueTempDir());
+
+  // Create a source extension.
+  std::string extension_id("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");
+  std::string version("1.0");
+  FilePath src = temp.path().AppendASCII(extension_id);
+  ASSERT_TRUE(file_util::CreateDirectory(src));
+
+  // Create a extensions tree.
+  FilePath all_extensions = temp.path().AppendASCII("extensions");
+  ASSERT_TRUE(file_util::CreateDirectory(all_extensions));
+
+  // Install in empty directory. Should create parent directories as needed.
+  FilePath version_1 = extension_file_util::InstallExtension(src,
+                                                             extension_id,
+                                                             version,
+                                                             all_extensions);
+  ASSERT_EQ(version_1.value(),
+            all_extensions.AppendASCII(extension_id).AppendASCII("1.0_0")
+                .value());
+  ASSERT_TRUE(file_util::DirectoryExists(version_1));
+
+  // Should have moved the source.
+  ASSERT_FALSE(file_util::DirectoryExists(src));
+
+  // Install again. Should create a new one with different name.
+  ASSERT_TRUE(file_util::CreateDirectory(src));
+  FilePath version_2 = extension_file_util::InstallExtension(src,
+                                                             extension_id,
+                                                             version,
+                                                             all_extensions);
+  ASSERT_EQ(version_2.value(),
+            all_extensions.AppendASCII(extension_id).AppendASCII("1.0_1")
+                .value());
+  ASSERT_TRUE(file_util::DirectoryExists(version_2));
+
+  // Collect garbage. Should remove first one.
+  std::map<std::string, FilePath> extension_paths;
+  extension_paths[extension_id] =
+      FilePath().AppendASCII(extension_id).Append(version_2.BaseName());
+  extension_file_util::GarbageCollectExtensions(all_extensions,
+                                                extension_paths);
+  ASSERT_FALSE(file_util::DirectoryExists(version_1));
+  ASSERT_TRUE(file_util::DirectoryExists(version_2));
+
+  // Uninstall. Should remove entire extension subtree.
+  extension_file_util::UninstallExtension(all_extensions, extension_id);
+  ASSERT_FALSE(file_util::DirectoryExists(version_2.DirName()));
+  ASSERT_TRUE(file_util::DirectoryExists(all_extensions));
+}
+
 TEST(ExtensionFileUtil, LoadExtensionWithValidLocales) {
   FilePath install_dir;
   ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &install_dir));
   install_dir = install_dir.AppendASCII("extensions")
       .AppendASCII("good")
       .AppendASCII("Extensions")
       .AppendASCII("behllobkkfkfnphdnhnkndlbkcpglgmj")
       .AppendASCII("1.0.0.0");
 
   std::string error;
@@ skipping 432 matching lines @@
       Extension::ERROR_ON_PRIVATE_KEY, &error);
   EXPECT_FALSE(extension.get());
   EXPECT_THAT(error,
               testing::ContainsRegex(
                   "extension includes the key file.*ext_root.a_key.pem"));
 }
 
 // TODO(aa): More tests as motivation allows. Maybe steal some from
 // ExtensionService? Many of them could probably be tested here without the
 // MessageLoop shenanigans.