Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2756)

Unified Diff: chrome/browser/sync/test/integration/sync_extension_helper.cc

Issue 10579028: Revert 142427 - Cleaning Up Extensions When Local Content Removed (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1180/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/test/integration/sync_extension_helper.cc
===================================================================
--- chrome/browser/sync/test/integration/sync_extension_helper.cc (revision 143046)
+++ chrome/browser/sync/test/integration/sync_extension_helper.cc (working copy)
@@ -18,8 +18,6 @@
#include "chrome/common/string_ordinal.h"
#include "chrome/browser/sync/test/integration/sync_test.h"
#include "chrome/browser/sync/test/integration/sync_datatype_helper.h"
-#include "chrome/test/base/ui_test_utils.h"
-#include "content/public/browser/browser_thread.h"
#include "testing/gtest/include/gtest/gtest.h"
using extensions::Extension;
@@ -72,16 +70,6 @@
NOTREACHED() << "Could not install extension " << name;
return "";
}
- // extensions::ExtensionGarbageCollector requires that there be a file present
- // on the file system for all extensions; we mimic this here. This also better
- // simulates the actual install process.
- content::BrowserThread::PostTask(
- content::BrowserThread::FILE, FROM_HERE,
- base::Bind(
- base::IgnoreResult(&file_util::CreateDirectory),
- profile->GetExtensionService()->install_directory()
- .AppendASCII(extension->id())));
- ui_test_utils::RunAllPendingInMessageLoop(content::BrowserThread::FILE);
profile->GetExtensionService()->OnExtensionInstalled(
extension, extension->UpdatesFromGallery(), StringOrdinal());
return extension->id();
« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698