Add a warning when developing an extension that uses old manifest version.

From the 'no free lunch' department: Add a warning when developing an extension that uses old manifest version.

Screen shot: http://imgur.com/dAHVo

BUG=131962
TBR=estade@chromium.org
TEST=Load any extension that uses manifest_version < 2. Should see warning message in chrome://extensions/.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141803

[Aaron Boodman, 2012-06-12 05:24:57]

yoz: extensiony stuff
estade: webuiy stuff

[Evan Stade, 2012-06-12 19:13:56]

http://codereview.chromium.org/10536084/diff/8002/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/10536084/diff/8002/chrome/app/generated_resour...
chrome/app/generated_resources.grd:4505: +        Manifest version 1 will be
unsupported soon. You should <ph name="LINK_START">$1<ex>&lt;a
href='http://code.google.com/chrome/extensions/manifestVersion.html'&gt;</ex></ph>upgrade
to version 2<ph name="LINK_END">$2<ex>&lt;/a&gt;</ex></ph>.
I don't feel strongly but I think that the normal way to do this is to add a
Learn More link at the end, rather than linkifying part of the text. This would
also simplify your code a bit.

[Yoyo Zhou, 2012-06-12 19:19:52]

LGTM for extensions, but it would be nice if there was a test.

http://codereview.chromium.org/10536084/diff/8002/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/10536084/diff/8002/chrome/app/generated_resour...
chrome/app/generated_resources.grd:4505: +        Manifest version 1 will be
unsupported soon. You should <ph name="LINK_START">$1<ex>&lt;a
href='http://code.google.com/chrome/extensions/manifestVersion.html'&gt;</ex></ph>upgrade
to version 2<ph name="LINK_END">$2<ex>&lt;/a&gt;</ex></ph>.
How about
Please upgrade to manifest version 2

[Aaron Boodman, 2012-06-13 00:19:49]

Added test full of fancy gmock matcher goodness.

http://codereview.chromium.org/10536084/diff/8002/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/10536084/diff/8002/chrome/app/generated_resour...
chrome/app/generated_resources.grd:4505: +        Manifest version 1 will be
unsupported soon. You should <ph name="LINK_START">$1<ex>&lt;a
href='http://code.google.com/chrome/extensions/manifestVersion.html'&gt;</ex></ph>upgrade
to version 2<ph name="LINK_END">$2<ex>&lt;/a&gt;</ex></ph>.
On 2012/06/12 19:13:56, Evan Stade wrote:
> I don't feel strongly but I think that the normal way to do this is to add a
> Learn More link at the end, rather than linkifying part of the text. This
would
> also simplify your code a bit.

Yeah, I thought about that, and tried to make it work. But I could not come up
with a way to phrase it that would fit on one line in English at the default
font size, which was important to me.

http://codereview.chromium.org/10536084/diff/8002/chrome/app/generated_resour...
chrome/app/generated_resources.grd:4505: +        Manifest version 1 will be
unsupported soon. You should <ph name="LINK_START">$1<ex>&lt;a
href='http://code.google.com/chrome/extensions/manifestVersion.html'&gt;</ex></ph>upgrade
to version 2<ph name="LINK_END">$2<ex>&lt;/a&gt;</ex></ph>.
On 2012/06/12 19:19:52, Yoyo Zhou wrote:
> How about
> Please upgrade to manifest version 2

I don't like the repetition of 'manifest'.

[Evan Stade, 2012-06-13 02:14:24]

seems like "Please upgrade to manifest version 2. Learn More" would be enough.

the code lgtm, the string is up to you