Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3666)

Unified Diff: chrome/common/extensions/manifest_unittest.cc

Issue 10536084: Add a warning when developing an extension that uses old manifest version. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: blonk Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/manifest_unittest.cc
diff --git a/chrome/common/extensions/manifest_unittest.cc b/chrome/common/extensions/manifest_unittest.cc
index 48f079f8c70a5621d3aaa2e8499714c7d3678161..f9359f5d7c7b8e7fa6d4ef107e56c74d6e2b8f6a 100644
--- a/chrome/common/extensions/manifest_unittest.cc
+++ b/chrome/common/extensions/manifest_unittest.cc
@@ -65,7 +65,7 @@ TEST_F(ManifestTest, Extension) {
scoped_ptr<Manifest> manifest(
new Manifest(Extension::INTERNAL, manifest_value.Pass()));
std::string error;
- std::vector<std::string> warnings;
+ Extension::InstallWarningVector warnings;
manifest->ValidateManifest(&error, &warnings);
EXPECT_TRUE(error.empty());
ASSERT_EQ(1u, warnings.size());
@@ -98,7 +98,7 @@ TEST_F(ManifestTest, Extension) {
feature.set_name("background_page");
feature.set_max_manifest_version(1);
EXPECT_EQ(feature.GetErrorMessage(Feature::INVALID_MAX_MANIFEST_VERSION),
- warnings[0]);
+ warnings[0].message);
}
// Test DeepCopy and Equals.
@@ -119,7 +119,7 @@ TEST_F(ManifestTest, ExtensionTypes) {
scoped_ptr<Manifest> manifest(
new Manifest(Extension::INTERNAL, value.Pass()));
std::string error;
- std::vector<std::string> warnings;
+ Extension::InstallWarningVector warnings;
manifest->ValidateManifest(&error, &warnings);
EXPECT_TRUE(error.empty());
EXPECT_TRUE(warnings.empty());
@@ -168,7 +168,7 @@ TEST_F(ManifestTest, RestrictedKeys) {
scoped_ptr<Manifest> manifest(
new Manifest(Extension::INTERNAL, value.Pass()));
std::string error;
- std::vector<std::string> warnings;
+ Extension::InstallWarningVector warnings;
manifest->ValidateManifest(&error, &warnings);
EXPECT_TRUE(error.empty());
EXPECT_TRUE(warnings.empty());
« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_manifest_version_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698