Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 10536084: Add a warning when developing an extension that uses old manifest version. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: blonk Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/extensions/extensions.css ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index b9f45f29f32c7da292ef061fdabaa56b10b8d14c..6e015965b3e1c2fce0b35a64fa5876e04a899b9c 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -187,13 +187,17 @@ DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
}
// Add install warnings (these are not the same as warnings!).
- const std::vector<std::string>& install_warnings =
+ const Extension::InstallWarningVector& install_warnings =
extension->install_warnings();
if (!install_warnings.empty()) {
scoped_ptr<ListValue> list(new ListValue());
- for (std::vector<std::string>::const_iterator it = install_warnings.begin();
- it != install_warnings.end(); ++it) {
- list->Append(Value::CreateStringValue(*it));
+ for (Extension::InstallWarningVector::const_iterator it =
+ install_warnings.begin(); it != install_warnings.end(); ++it) {
+ DictionaryValue* item = new DictionaryValue();
+ item->SetBoolean("isHTML",
+ it->format == Extension::InstallWarning::FORMAT_HTML);
+ item->SetString("message", it->message);
+ list->Append(item);
}
extension_data->Set("installWarnings", list.release());
}
« no previous file with comments | « chrome/browser/resources/extensions/extensions.css ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698