Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chrome/common/extensions/manifest.h

Issue 10536084: Add a warning when developing an extension that uses old manifest version. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: blonk Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/common/extensions/extension_unpacker.cc ('k') | chrome/common/extensions/manifest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_H_
6 #define CHROME_COMMON_EXTENSIONS_MANIFEST_H_ 6 #define CHROME_COMMON_EXTENSIONS_MANIFEST_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 15 matching lines...) Expand all
26 26
27 const std::string& extension_id() const { return extension_id_; } 27 const std::string& extension_id() const { return extension_id_; }
28 void set_extension_id(const std::string& id) { extension_id_ = id; } 28 void set_extension_id(const std::string& id) { extension_id_ = id; }
29 29
30 Extension::Location location() const { return location_; } 30 Extension::Location location() const { return location_; }
31 31
32 // |error| will be non-empty if the manifest is malformed. |warnings| will 32 // |error| will be non-empty if the manifest is malformed. |warnings| will
33 // be populated if there are keys in the manifest that cannot be specified by 33 // be populated if there are keys in the manifest that cannot be specified by
34 // the extension type. 34 // the extension type.
35 void ValidateManifest(std::string* error, 35 void ValidateManifest(std::string* error,
36 std::vector<std::string>* warnings) const; 36 Extension::InstallWarningVector* warnings) const;
37 37
38 // The version of this extension's manifest. We increase the manifest 38 // The version of this extension's manifest. We increase the manifest
39 // version when making breaking changes to the extension system. If the 39 // version when making breaking changes to the extension system. If the
40 // manifest contains no explicit manifest version, this returns the current 40 // manifest contains no explicit manifest version, this returns the current
41 // system default. 41 // system default.
42 int GetManifestVersion() const; 42 int GetManifestVersion() const;
43 43
44 // Returns the manifest type. 44 // Returns the manifest type.
45 Extension::Type type() const { return type_; } 45 Extension::Type type() const { return type_; }
46 46
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 scoped_ptr<base::DictionaryValue> value_; 91 scoped_ptr<base::DictionaryValue> value_;
92 92
93 Extension::Type type_; 93 Extension::Type type_;
94 94
95 DISALLOW_COPY_AND_ASSIGN(Manifest); 95 DISALLOW_COPY_AND_ASSIGN(Manifest);
96 }; 96 };
97 97
98 } // namespace extensions 98 } // namespace extensions
99 99
100 #endif // CHROME_COMMON_EXTENSIONS_MANIFEST_H_ 100 #endif // CHROME_COMMON_EXTENSIONS_MANIFEST_H_
OLDNEW
« no previous file with comments | « chrome/common/extensions/extension_unpacker.cc ('k') | chrome/common/extensions/manifest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698