Issue 10388253: Revert 138502 - Move version metadata from PluginGroup into PluginInstaller.

Issue 10388253: Revert 138502 - Move version metadata from PluginGroup into PluginInstaller. (Closed)

Created:
8 years, 7 months ago by vandebo (ex-Chrome)

Modified:
8 years, 7 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jam, Aaron Boodman, arv (Not doing code reviews), darin-cc_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 138502 - Move version metadata from PluginGroup into PluginInstaller. See: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/7042/steps/compile/logs/stdio This also moves the plug-in information JSON files into their own subdirectory, so they can be changed without requiring OWNERS reviews for chrome/browser/resources (which is mostly WebUI otherwise). BUG=124396 TEST=PluginInstallerTest.SecurityStatus:PluginFinderTest.JsonSyntax Review URL: https://chromiumcodereview.appspot.com/10263022 TBR=bauerb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138514

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+518 lines, -913 lines)			Patch
M	chrome/browser/browser_resources.grd	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/content_settings/content_settings_apitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/plugin_finder.cc	View	1 chunk	+5 lines, -26 lines	0 comments	Download
M	chrome/browser/plugin_finder_unittest.cc	View	2 chunks	+14 lines, -16 lines	0 comments	Download
M	chrome/browser/plugin_infobar_delegates.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/plugin_installer.h	View	5 chunks	+20 lines, -43 lines	0 comments	Download
M	chrome/browser/plugin_installer.cc	View	6 chunks	+20 lines, -70 lines	0 comments	Download
D	chrome/browser/plugin_installer_unittest.cc	View	1 chunk	+0 lines, -53 lines	0 comments	Download
M	chrome/browser/plugin_observer.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/plugin_info_message_filter.cc	View	1 chunk	+10 lines, -13 lines	0 comments	Download
D	chrome/browser/resources/plugin_metadata/OWNERS	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	chrome/browser/resources/plugin_metadata/plugins_linux.json	View	1 chunk	+0 lines, -116 lines	0 comments	Download
D	chrome/browser/resources/plugin_metadata/plugins_mac.json	View	1 chunk	+0 lines, -242 lines	0 comments	Download
D	chrome/browser/resources/plugin_metadata/plugins_win.json	View	1 chunk	+0 lines, -252 lines	0 comments	Download
A +	chrome/browser/resources/plugins_linux.json	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/resources/plugins_mac.json	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/resources/plugins_win.json	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/ui/pdf/pdf_unsupported_feature.cc	View	9 chunks	+26 lines, -33 lines	0 comments	Download
M	chrome/browser/ui/webui/plugins_ui.cc	View	1 chunk	+5 lines, -6 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_group.h	View	6 chunks	+53 lines, -0 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_group.cc	View	5 chunks	+93 lines, -4 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_group_unittest.cc	View	2 chunks	+153 lines, -2 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_list.cc	View	3 chunks	+110 lines, -23 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_list_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages