Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: chrome/browser/plugin_finder_unittest.cc

Issue 10388253: Revert 138502 - Move version metadata from PluginGroup into PluginInstaller. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/plugin_finder.cc ('k') | chrome/browser/plugin_infobar_delegates.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/plugin_finder.h" 5 #include "chrome/browser/plugin_finder.h"
6 6
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/browser/plugin_installer.h"
9 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
10 #include "webkit/plugins/npapi/plugin_list.h" 9 #include "webkit/plugins/npapi/plugin_list.h"
11 10
12 using base::DictionaryValue; 11 using base::DictionaryValue;
13 using webkit::npapi::PluginGroup; 12 using webkit::npapi::PluginGroup;
14 using webkit::npapi::PluginList; 13 using webkit::npapi::PluginList;
15 14
16 TEST(PluginFinderTest, JsonSyntax) { 15 TEST(PluginFinderTest, JsonSyntax) {
17 scoped_ptr<DictionaryValue> plugin_list(PluginFinder::LoadPluginList()); 16 scoped_ptr<DictionaryValue> plugin_list(PluginFinder::LoadPluginList());
18 ASSERT_TRUE(plugin_list.get()); 17 ASSERT_TRUE(plugin_list.get());
(...skipping 11 matching lines...) Expand all
30 if (plugin->HasKey("displayurl")) 29 if (plugin->HasKey("displayurl"))
31 EXPECT_TRUE(plugin->GetBoolean("displayurl", &dummy_bool)); 30 EXPECT_TRUE(plugin->GetBoolean("displayurl", &dummy_bool));
32 if (plugin->HasKey("requires_authorization")) 31 if (plugin->HasKey("requires_authorization"))
33 EXPECT_TRUE(plugin->GetBoolean("requires_authorization", &dummy_bool)); 32 EXPECT_TRUE(plugin->GetBoolean("requires_authorization", &dummy_bool));
34 ListValue* mime_types = NULL; 33 ListValue* mime_types = NULL;
35 ASSERT_TRUE(plugin->GetList("mime_types", &mime_types)); 34 ASSERT_TRUE(plugin->GetList("mime_types", &mime_types));
36 for (ListValue::const_iterator mime_type_it = mime_types->begin(); 35 for (ListValue::const_iterator mime_type_it = mime_types->begin();
37 mime_type_it != mime_types->end(); ++mime_type_it) { 36 mime_type_it != mime_types->end(); ++mime_type_it) {
38 EXPECT_TRUE((*mime_type_it)->GetAsString(&dummy_str)); 37 EXPECT_TRUE((*mime_type_it)->GetAsString(&dummy_str));
39 } 38 }
40 ListValue* versions = NULL;
41 if (!plugin->GetList("versions", &versions))
42 continue;
43
44 for (ListValue::const_iterator it = versions->begin();
45 it != versions->end(); ++it) {
46 DictionaryValue* version_dict = NULL;
47 ASSERT_TRUE((*it)->GetAsDictionary(&version_dict));
48 EXPECT_TRUE(version_dict->GetString("version", &dummy_str));
49 std::string status_str;
50 EXPECT_TRUE(version_dict->GetString("status", &status_str));
51 PluginInstaller::SecurityStatus status =
52 PluginInstaller::SECURITY_STATUS_UP_TO_DATE;
53 EXPECT_TRUE(PluginInstaller::ParseSecurityStatus(status_str, &status))
54 << "Invalid security status \"" << status_str << "\"";
55 }
56 } 39 }
57 } 40 }
41
42 TEST(PluginFinderTest, PluginGroups) {
43 PluginFinder plugin_finder;
44 PluginList* plugin_list = PluginList::Singleton();
45 const std::vector<PluginGroup*>& plugin_groups =
46 plugin_list->GetHardcodedPluginGroups();
47 for (std::vector<PluginGroup*>::const_iterator it = plugin_groups.begin();
48 it != plugin_groups.end(); ++it) {
49 if ((*it)->version_ranges().empty())
50 continue;
51 std::string identifier = (*it)->identifier();
52 EXPECT_TRUE(plugin_finder.FindPluginWithIdentifier(identifier)) <<
53 "Couldn't find PluginInstaller for '" << identifier << "'";
54 }
55 }
OLDNEW
« no previous file with comments | « chrome/browser/plugin_finder.cc ('k') | chrome/browser/plugin_infobar_delegates.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698