chrome/browser/ui/webui/plugins_ui.cc - Issue 10388253: Revert 138502 - Move version metadata from PluginGroup into PluginInstaller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/plugins_ui.cc

Issue 10388253: Revert 138502 - Move version metadata from PluginGroup into PluginInstaller. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/plugins_ui.cc

===================================================================

--- chrome/browser/ui/webui/plugins_ui.cc (revision 138513)

+++ chrome/browser/ui/webui/plugins_ui.cc (working copy)

@@ -426,17 +426,16 @@

group_data->SetString("id", group.identifier());

group_data->SetString("description", active_plugin->desc);

group_data->SetString("version", active_plugin->version);

+ group_data->SetBoolean("critical", group.IsVulnerable(*active_plugin));

+ std::string update_url;

#if defined(ENABLE_PLUGIN_INSTALLATION)

PluginInstaller* installer =

plugin_finder->FindPluginWithIdentifier(group.identifier());

- if (installer) {

- bool out_of_date = installer->GetSecurityStatus(*active_plugin) ==

- PluginInstaller::SECURITY_STATUS_OUT_OF_DATE;

- group_data->SetBoolean("critical", out_of_date);

- group_data->SetString("update_url", installer->plugin_url().spec());

- }

+ if (installer)

+ update_url = installer->plugin_url().spec();

#endif

+ group_data->SetString("update_url", update_url);

std::string enabled_mode;

if (all_plugins_enabled_by_policy) {

« no previous file with comments | « chrome/browser/ui/pdf/pdf_unsupported_feature.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »