Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1577)

Unified Diff: chrome/browser/plugin_infobar_delegates.cc

Issue 10388253: Revert 138502 - Move version metadata from PluginGroup into PluginInstaller. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugin_finder_unittest.cc ('k') | chrome/browser/plugin_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugin_infobar_delegates.cc
===================================================================
--- chrome/browser/plugin_infobar_delegates.cc (revision 138513)
+++ chrome/browser/plugin_infobar_delegates.cc (working copy)
@@ -150,11 +150,11 @@
PluginInstaller* installer) {
string16 message;
switch (installer->state()) {
- case PluginInstaller::INSTALLER_STATE_IDLE:
+ case PluginInstaller::kStateIdle:
message = l10n_util::GetStringFUTF16(IDS_PLUGIN_OUTDATED_PROMPT,
installer->name());
break;
- case PluginInstaller::INSTALLER_STATE_DOWNLOADING:
+ case PluginInstaller::kStateDownloading:
message = l10n_util::GetStringFUTF16(IDS_PLUGIN_DOWNLOADING,
installer->name());
break;
@@ -216,7 +216,7 @@
bool OutdatedPluginInfoBarDelegate::Accept() {
content::RecordAction(UserMetricsAction("OutdatedPluginInfobar.Update"));
- if (installer()->state() != PluginInstaller::INSTALLER_STATE_IDLE) {
+ if (installer()->state() != PluginInstaller::kStateIdle) {
NOTREACHED();
return false;
}
@@ -314,11 +314,11 @@
string16 message;
const string16& plugin_name = installer->name();
switch (installer->state()) {
- case PluginInstaller::INSTALLER_STATE_IDLE:
+ case PluginInstaller::kStateIdle:
message = l10n_util::GetStringFUTF16(
IDS_PLUGININSTALLER_INSTALLPLUGIN_PROMPT, plugin_name);
break;
- case PluginInstaller::INSTALLER_STATE_DOWNLOADING:
+ case PluginInstaller::kStateDownloading:
message = l10n_util::GetStringFUTF16(IDS_PLUGIN_DOWNLOADING, plugin_name);
break;
}
« no previous file with comments | « chrome/browser/plugin_finder_unittest.cc ('k') | chrome/browser/plugin_installer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698