Issue 10383207: Fix new -Wnull-conversion violations detected by a newer clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10383207: Fix new -Wnull-conversion violations detected by a newer clang. (Closed)

Created:
8 years, 7 months ago by Nico

Modified:
8 years, 7 months ago

Reviewers:
Lei Zhang, hans

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix new -Wnull-conversion violations detected by a newer clang. No intended behavior change. BUG=none TEST=none TBR=hans Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137374

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -7 lines)			Patch
M	chrome/browser/debugger/devtools_window.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/test_extension_service.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/zip_reader.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	printing/pdf_metafile_skia.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/sudden_motion_sensor/sudden_motion_sensor_mac.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10383207/1

8 years, 7 months ago (2012-05-16 05:22:06 UTC) #2

hans

8 years, 7 months ago (2012-05-16 09:39:57 UTC) #5

On 2012/05/16 05:21:47, Nico wrote:
> You reviewed the sudden motion code, who would've thought!

LGTM

Good thing we have tools to make up for my lacking scrutiny in reviews :)

Expand Messages | Collapse Messages