chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc - Issue 10383207: Fix new -Wnull-conversion violations detected by a newer clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

Issue 10383207: Fix new -Wnull-conversion violations detected by a newer clang. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

diff --git a/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc b/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

index 52e9da98ed5b1d1d9709891a5bd556eaecc30911..654b61f1c3fca5c80c6fb3b5cb6d3edf8605be55 100644

--- a/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

+++ b/chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc

@@ -544,7 +544,7 @@ GetAllOffscreenTabFunction::~GetAllOffscreenTabFunction() {}

bool GetAllOffscreenTabFunction::RunImpl() {

WebContents* web_contents = GetCurrentWebContents(this, &error_);

if (!web_contents)

- return NULL;

+ return false;

ParentTab* parent_tab = GetMap()->GetParentTab(web_contents, extension_id());

ListValue* tab_list = new ListValue();