Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: chrome/browser/extensions/test_extension_service.cc

Issue 10383207: Fix new -Wnull-conversion violations detected by a newer clang. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/crx_installer.h" 5 #include "chrome/browser/extensions/crx_installer.h"
6 #include "chrome/browser/extensions/extension_sync_data.h" 6 #include "chrome/browser/extensions/extension_sync_data.h"
7 #include "chrome/browser/extensions/test_extension_service.h" 7 #include "chrome/browser/extensions/test_extension_service.h"
8 #include "sync/api/sync_error_factory.h" 8 #include "sync/api/sync_error_factory.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 13 matching lines...) Expand all
24 ADD_FAILURE(); 24 ADD_FAILURE();
25 return NULL; 25 return NULL;
26 } 26 }
27 27
28 bool TestExtensionService::UpdateExtension( 28 bool TestExtensionService::UpdateExtension(
29 const std::string& id, 29 const std::string& id,
30 const FilePath& path, 30 const FilePath& path,
31 const GURL& download_url, 31 const GURL& download_url,
32 CrxInstaller** out_crx_installer) { 32 CrxInstaller** out_crx_installer) {
33 ADD_FAILURE(); 33 ADD_FAILURE();
34 return NULL; 34 return false;
35 } 35 }
36 36
37 const Extension* TestExtensionService::GetExtensionById( 37 const Extension* TestExtensionService::GetExtensionById(
38 const std::string& id, bool include_disabled) const { 38 const std::string& id, bool include_disabled) const {
39 ADD_FAILURE(); 39 ADD_FAILURE();
40 return NULL; 40 return NULL;
41 } 41 }
42 42
43 const Extension* TestExtensionService::GetInstalledExtension( 43 const Extension* TestExtensionService::GetInstalledExtension(
44 const std::string& id) const { 44 const std::string& id) const {
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 void TestExtensionService::UnloadExtension( 109 void TestExtensionService::UnloadExtension(
110 const std::string& extension_id, 110 const std::string& extension_id,
111 extension_misc::UnloadedExtensionReason reason) { 111 extension_misc::UnloadedExtensionReason reason) {
112 ADD_FAILURE(); 112 ADD_FAILURE();
113 } 113 }
114 114
115 void TestExtensionService::SyncExtensionChangeIfNeeded( 115 void TestExtensionService::SyncExtensionChangeIfNeeded(
116 const Extension& extension) { 116 const Extension& extension) {
117 ADD_FAILURE(); 117 ADD_FAILURE();
118 } 118 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc ('k') | chrome/common/zip_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698