printing/pdf_metafile_skia.cc - Issue 10383207: Fix new -Wnull-conversion violations detected by a newer clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/pdf_metafile_skia.cc

Issue 10383207: Fix new -Wnull-conversion violations detected by a newer clang. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: printing/pdf_metafile_skia.cc

diff --git a/printing/pdf_metafile_skia.cc b/printing/pdf_metafile_skia.cc

index fdff44f56cf80175944d2be42ebe2278853e4c57..b1b35edde81a32fc7b758029844b5a11c678520d 100644

--- a/printing/pdf_metafile_skia.cc

+++ b/printing/pdf_metafile_skia.cc

@@ -73,7 +73,7 @@ bool PdfMetafileSkia::StartPage(const gfx::Size& page_size,

const gfx::Rect& content_area,

const float& scale_factor) {

NOTREACHED();

- return NULL;

+ return false;

}

bool PdfMetafileSkia::FinishPage() {