Move keyboard related methods from RenderViewHostDelegate to a new RenderWidgetHostDelegate

Move keyboard related methods from RenderViewHostDelegate to a new RenderWidgetHostDelegate

That way, a WebContentsDelegate gets to handle the keyboard events also for widgets spawned by the WebContents

BUG=none
TEST=what could possibly go wrong?


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137436

[jochen (gone - plz use gerrit), 2012-05-15 23:05:58]

lots of moving code around

John/Brett/Ben: is this ok?

Yusuke: would this solve your problem?

[jam, 2012-05-16 06:37:49]

lgtm

http://codereview.chromium.org/10377158/diff/2001/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

http://codereview.chromium.org/10377158/diff/2001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_impl.cc:136: CHECK(delegate_); 
// http://crbug.com/82827
wrong bug number?

[Yusuke Sato, 2012-05-16 07:44:56]

> Yusuke: would this solve your problem?

Yes! I've confirmed that Chrome can correctly handle accelerators with the CL.
Thanks a lot for fixing this quickly.

[jochen (gone - plz use gerrit), 2012-05-16 11:01:51]

http://codereview.chromium.org/10377158/diff/2001/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

http://codereview.chromium.org/10377158/diff/2001/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_impl.cc:136: CHECK(delegate_); 
// http://crbug.com/82827
On 2012/05/16 06:37:49, John Abd-El-Malek wrote:
> wrong bug number?

This is taken from the constructor of RenderViewHostImpl. If somebody manages to
create a RVH with a NULL delegate, I figured they'd also pass a NULL delegate to
RWH.

OTOH, the CHECK in RVH should be enough to catch this if it happens again, so I
could as well remove the CHECK here?

[commit-bot: I haz the power, 2012-05-16 14:55:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/10377158/57

[commit-bot: I haz the power, 2012-05-16 16:19:10]

Change committed as 137436