content/browser/renderer_host/render_view_host_impl.h - Issue 10377158: Move keyboard related methods from RenderViewHostDelegate to a new RenderWidgetHostDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 10377158: Move keyboard related methods from RenderViewHostDelegate to a new RenderWidgetHostDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove crbug link Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_factory.cc ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.h

diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h

index 63573baefd7a13f9fee86757babe9d5420f0720e..dc7c55ef913860350b2bdf961fa2544dd6699b3e 100644

--- a/content/browser/renderer_host/render_view_host_impl.h

+++ b/content/browser/renderer_host/render_view_host_impl.h

@@ -61,6 +61,7 @@ namespace content {

class SessionStorageNamespace;

class RenderViewHostObserver;

+class RenderWidgetHostDelegate;

struct FileChooserParams;

struct ContextMenuParams;

struct Referrer;

@@ -134,6 +135,7 @@ class CONTENT_EXPORT RenderViewHostImpl

RenderViewHostImpl(

SiteInstance* instance,

RenderViewHostDelegate* delegate,

+ RenderWidgetHostDelegate* widget_delegate,

int routing_id,

bool swapped_out,

SessionStorageNamespace* session_storage_namespace);

@@ -425,10 +427,6 @@ class CONTENT_EXPORT RenderViewHostImpl

void RemoveObserver(RenderViewHostObserver* observer);

// RenderWidgetHost protected overrides.

- virtual bool PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event,

- bool* is_keyboard_shortcut) OVERRIDE;

- virtual void UnhandledKeyboardEvent(

- const NativeWebKeyboardEvent& event) OVERRIDE;

virtual void OnUserGesture() OVERRIDE;

virtual void NotifyRendererUnresponsive() OVERRIDE;

virtual void NotifyRendererResponsive() OVERRIDE;