Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 10377158: Move keyboard related methods from RenderViewHostDelegate to a new RenderWidgetHostDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove crbug link Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index aa0c6ac8063c1264afed7e738551ad99d957527f..9be41250ba95318ea8ec525cc2969f263b97463b 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -130,12 +130,14 @@ RenderViewHostImpl* RenderViewHostImpl::FromID(int render_process_id,
RenderViewHost::FromID(render_process_id, render_view_id));
}
-RenderViewHostImpl::RenderViewHostImpl(SiteInstance* instance,
- RenderViewHostDelegate* delegate,
- int routing_id,
- bool swapped_out,
- SessionStorageNamespace* session_storage)
- : RenderWidgetHostImpl(instance->GetProcess(), routing_id),
+RenderViewHostImpl::RenderViewHostImpl(
+ SiteInstance* instance,
+ RenderViewHostDelegate* delegate,
+ RenderWidgetHostDelegate* widget_delegate,
+ int routing_id,
+ bool swapped_out,
+ SessionStorageNamespace* session_storage)
+ : RenderWidgetHostImpl(widget_delegate, instance->GetProcess(), routing_id),
delegate_(delegate),
instance_(static_cast<SiteInstanceImpl*>(instance)),
waiting_for_drag_context_response_(false),
@@ -1397,16 +1399,6 @@ void RenderViewHostImpl::RemoveObserver(
observers_.RemoveObserver(observer);
}
-bool RenderViewHostImpl::PreHandleKeyboardEvent(
- const NativeWebKeyboardEvent& event, bool* is_keyboard_shortcut) {
- return delegate_->PreHandleKeyboardEvent(event, is_keyboard_shortcut);
-}
-
-void RenderViewHostImpl::UnhandledKeyboardEvent(
- const NativeWebKeyboardEvent& event) {
- delegate_->HandleKeyboardEvent(event);
-}
-
void RenderViewHostImpl::OnUserGesture() {
delegate_->OnUserGesture();
}
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/browser/renderer_host/render_widget_host_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698