Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1255)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 10377158: Move keyboard related methods from RenderViewHostDelegate to a new RenderWidgetHostDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove crbug link Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 969623fdcc81142aeb2134b9edd79d5ef8ab5741..e0c1cf4086d5e280a610612db3df2b5989017978 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -16,6 +16,7 @@
#include "base/property_bag.h"
#include "content/browser/browser_plugin/browser_plugin_web_contents_observer.h"
#include "content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.h"
+#include "content/browser/renderer_host/render_widget_host_delegate.h"
#include "content/browser/web_contents/navigation_controller_impl.h"
#include "content/browser/web_contents/render_view_host_manager.h"
#include "content/common/content_export.h"
@@ -58,6 +59,7 @@ struct WebIntentData;
class CONTENT_EXPORT WebContentsImpl
: public NON_EXPORTED_BASE(content::WebContents),
public content::RenderViewHostDelegate,
+ public content::RenderWidgetHostDelegate,
public RenderViewHostManager::Delegate,
public content::NotificationObserver {
public:
@@ -343,10 +345,6 @@ class CONTENT_EXPORT WebContentsImpl
virtual void Activate() OVERRIDE;
virtual void Deactivate() OVERRIDE;
virtual void LostCapture() OVERRIDE;
- virtual bool PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event,
- bool* is_keyboard_shortcut) OVERRIDE;
- virtual void HandleKeyboardEvent(
- const NativeWebKeyboardEvent& event) OVERRIDE;
virtual void HandleMouseDown() OVERRIDE;
virtual void HandleMouseUp() OVERRIDE;
virtual void HandleMouseActivate() OVERRIDE;
@@ -360,6 +358,13 @@ class CONTENT_EXPORT WebContentsImpl
virtual void RequestToLockMouse(bool user_gesture) OVERRIDE;
virtual void LostMouseLock() OVERRIDE;
+ // RenderWidgetHostDelegate --------------------------------------------------
+
+ virtual bool PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event,
+ bool* is_keyboard_shortcut) OVERRIDE;
+ virtual void HandleKeyboardEvent(
+ const NativeWebKeyboardEvent& event) OVERRIDE;
+
// RenderViewHostManager::Delegate -------------------------------------------
virtual bool CreateRenderViewForRenderManager(
« no previous file with comments | « content/browser/web_contents/render_view_host_manager_unittest.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698