Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 10340002: Don't support spaces in command, simplify msvs_emulation (Closed)

Created:
8 years, 7 months ago by scottmg
Modified:
8 years, 7 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Don't support spaces in command, simplify msvs_emulation The batch-file-with-space test doesn't work for the msvs generators. I looked at trying to fix it, but it got overly complicated because the VS generators don't distinguish between the program and arguments to the program. In general, I don't think gyp really supports spaces in filenames so it doesn't seem worth spending the effort going down that path. So, test that it doesn't work for all generators, and simplify msvs_emulation for ninja. R=thakis@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1353

Patch Set 1 #

Patch Set 2 : explicitly don't support spaces in command name, simplify msvs_emulation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M pylib/gyp/msvs_emulation.py View 1 1 chunk +5 lines, -12 lines 0 comments Download
M test/win/gyptest-command-quote.py View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
8 years, 7 months ago (2012-05-02 17:53:08 UTC) #1
Nico
Removing the third target sounds better to me. If MSVC doesn't get this right, winja ...
8 years, 7 months ago (2012-05-02 17:59:46 UTC) #2
scottmg
Amended to have third test explicitly fail, and remove special cases from msvs_emulation.
8 years, 7 months ago (2012-05-02 19:15:28 UTC) #3
Nico
8 years, 7 months ago (2012-05-02 20:53:48 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698