Don't support spaces in command, simplify msvs_emulation

pylib/gyp/msvs_emulation.py

 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 This module helps emulate Visual Studio 2008 behavior on top of other
 build systems, primarily ninja.
 """
 
 import os
@@ skipping 35 matching lines @@
   # These commands are used in rsp files, so no escaping for the shell (via ^)
   # is necessary.
 
   # Finally, wrap the whole thing in quotes so that the above quote rule
   # applies and whitespace isn't a word break.
   return '"' + arg + '"'
 
 
 def EncodeRspFileList(args):
   """Process a list of arguments using QuoteCmdExeArgument."""
-  # Note that the first argument is assumed to be the command. We take extra
-  # steps to make sure that calls to .bat files are handled correctly, and
-  # that paths are normalized and quoted as necessary.
+  # Note that the first argument is assumed to be the command. Don't add
+  # quotes around it because then commands like 'call x.bat' or shell
+  # built-ins like 'echo', etc. won't work. Also, don't bother special casing
+  # to get quotes around the remainder (after 'call') since other generators
+  # and gyp in general don't really support spaces in paths.
   if not args: return ''
   program = args[0]
-  if program.startswith('call '):
-    call, batch = program.split(' ', 1)
-    program = 'call ' + QuoteForRspFile(os.path.normpath(batch))
-  else:
-    program = os.path.normpath(program)
-    # Don't add quotes around things without spaces so that 'call', 'echo',
-    # etc. will work if they're specified as individual arguments.
-    if ' ' in program:
-      program = QuoteForRspFile(program)
   return program + ' ' + ' '.join(QuoteForRspFile(arg) for arg in args[1:])
 
 
 def _GenericRetrieve(root, default, path):
   """Given a list of dictionary keys |path| and a tree of dicts |root|, find
   value at path, or return |default| if any of the path doesn't exist."""
   if not root:
     return default
   if not path:
     return root
@@ skipping 404 matching lines @@
         vs.Path(), r'Common7\Tools\vsvars32.bat'))
 
 def ExpandMacros(string, expansions):
   """Expand $(Variable) per expansions dict. See MsvsSettings.GetVSMacroEnv
   for the canonical way to retrieve a suitable dict."""
   if '$' in string:
     for old, new in expansions.iteritems():
       assert '$(' not in new, new
       string = string.replace(old, new)
   return string