Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: test/win/gyptest-command-quote.py

Issue 10340002: Don't support spaces in command, simplify msvs_emulation (Closed) Base URL: https://gyp.googlecode.com/svn/trunk
Patch Set: explicitly don't support spaces in command name, simplify msvs_emulation Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pylib/gyp/msvs_emulation.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 2
3 # Copyright (c) 2012 Google Inc. All rights reserved. 3 # Copyright (c) 2012 Google Inc. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """ 7 """
8 8
9 Make sure the program in a command can be a called batch file, or an 9 Make sure the program in a command can be a called batch file, or an
10 application in the path. Specifically, this means not quoting something like 10 application in the path. Specifically, this means not quoting something like
11 "call x.bat", lest the shell look for a program named "call x.bat", rather 11 "call x.bat", lest the shell look for a program named "call x.bat", rather
12 than calling "x.bat". 12 than calling "x.bat".
13 """ 13 """
14 14
15 import TestGyp 15 import TestGyp
16 16
17 import sys 17 import sys
18 18
19 if sys.platform == 'win32': 19 if sys.platform == 'win32':
20 test = TestGyp.TestGyp(formats=['msvs', 'ninja']) 20 test = TestGyp.TestGyp(formats=['msvs', 'ninja'])
21 CHDIR = 'command-quote' 21 CHDIR = 'command-quote'
22 test.run_gyp('command-quote.gyp', chdir=CHDIR) 22 test.run_gyp('command-quote.gyp', chdir=CHDIR)
23 test.build('command-quote.gyp', test.ALL, chdir=CHDIR) 23
24 test.build('command-quote.gyp', 'test_batch', chdir=CHDIR)
25 test.build('command-quote.gyp', 'test_call_separate', chdir=CHDIR)
26
27 # We confirm that this fails because other generators don't handle spaces in
28 # inputs so it's preferable to not have it work here.
29 test.build('command-quote.gyp', 'test_with_spaces', chdir=CHDIR, status=1)
30
24 test.pass_test() 31 test.pass_test()
OLDNEW
« no previous file with comments | « pylib/gyp/msvs_emulation.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698