Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2044)

Unified Diff: test/win/gyptest-command-quote.py

Issue 10340002: Don't support spaces in command, simplify msvs_emulation (Closed) Base URL: https://gyp.googlecode.com/svn/trunk
Patch Set: explicitly don't support spaces in command name, simplify msvs_emulation Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylib/gyp/msvs_emulation.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/win/gyptest-command-quote.py
diff --git a/test/win/gyptest-command-quote.py b/test/win/gyptest-command-quote.py
index 7f873f2aad02a2e632fca11919da0ed7e292ab37..9303273aac908d62c276183fc7b29e928decc4ae 100644
--- a/test/win/gyptest-command-quote.py
+++ b/test/win/gyptest-command-quote.py
@@ -20,5 +20,12 @@ if sys.platform == 'win32':
test = TestGyp.TestGyp(formats=['msvs', 'ninja'])
CHDIR = 'command-quote'
test.run_gyp('command-quote.gyp', chdir=CHDIR)
- test.build('command-quote.gyp', test.ALL, chdir=CHDIR)
+
+ test.build('command-quote.gyp', 'test_batch', chdir=CHDIR)
+ test.build('command-quote.gyp', 'test_call_separate', chdir=CHDIR)
+
+ # We confirm that this fails because other generators don't handle spaces in
+ # inputs so it's preferable to not have it work here.
+ test.build('command-quote.gyp', 'test_with_spaces', chdir=CHDIR, status=1)
+
test.pass_test()
« no previous file with comments | « pylib/gyp/msvs_emulation.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698