Issue 10134010: Fix source property of empty RegExp objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10134010: Fix source property of empty RegExp objects. (Closed)

Created:
8 years, 8 months ago by Michael Starzinger

Modified:
8 years, 8 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix source property of empty RegExp objects. R=rossberg@chromium.org BUG=v8:1982 TEST=test262/15.10.4.1-5 Committed: https://code.google.com/p/v8/source/detail?r=11416

Patch Set 2 : Addressed comment by Andreas Rossberg. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -11 lines)			Patch
M	src/bootstrapper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/regexp.js	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/mjsunit/regress/regress-1217.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mozilla/mozilla.status	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	test/sputnik/sputnik.status	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	test/test262/test262.status	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rossberg

lgtm https://chromiumcodereview.appspot.com/10134010/diff/1/test/test262/test262.status File test/test262/test262.status (right): https://chromiumcodereview.appspot.com/10134010/diff/1/test/test262/test262.status#newcode36 test/test262/test262.status:36: # V8 Bug: http://code.google.com/p/v8/issues/detail?id=691 While you're at it, ...

8 years, 8 months ago (2012-04-23 13:12:29 UTC) #2

Michael Starzinger

8 years, 8 months ago (2012-04-23 13:43:23 UTC) #3

Added new patch set.

https://chromiumcodereview.appspot.com/10134010/diff/1/test/test262/test262.s...
File test/test262/test262.status (right):

https://chromiumcodereview.appspot.com/10134010/diff/1/test/test262/test262.s...
test/test262/test262.status:36: # V8 Bug:
http://code.google.com/p/v8/issues/detail?id=691
On 2012/04/23 13:12:29, rossberg wrote:
> While you're at it, can you add brief descriptive comments to these two
> failures?

Done.

Expand Messages | Collapse Messages

Issue 10134010: Fix source property of empty RegExp objects. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comment by Andreas Rossberg. #

Messages