src/runtime.cc - Issue 10134010: Fix source property of empty RegExp objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 10134010: Fix source property of empty RegExp objects. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comment by Andreas Rossberg. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index a344b28e0a030bcfc2410849ad8fa5a65b26153e..39310123e48440d33e0f59bcd576aec2270cbdea 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -1780,6 +1780,9 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_RegExpInitializeObject) {

ASSERT(args.length() == 5);

CONVERT_ARG_CHECKED(JSRegExp, regexp, 0);

CONVERT_ARG_CHECKED(String, source, 1);

+ // If source is the empty string we set it to "(?:)" instead as

+ // suggested by ECMA-262, 5th, section 15.10.4.1.

+ if (source->length() == 0) source = isolate->heap()->query_colon_symbol();

Object* global = args[2];

if (!global->IsTrue()) global = isolate->heap()->false_value();

« no previous file with comments | « src/regexp.js ('k') | test/mjsunit/regress/regress-1217.js » ('j') | no next file with comments »