Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: src/bootstrapper.cc

Issue 10134010: Fix source property of empty RegExp objects. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment by Andreas Rossberg. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/heap.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 993 matching lines...) Expand 10 before | Expand all | Expand 10 after
1004 initial_map->set_instance_size( 1004 initial_map->set_instance_size(
1005 initial_map->instance_size() + 5 * kPointerSize); 1005 initial_map->instance_size() + 5 * kPointerSize);
1006 initial_map->set_instance_descriptors(*descriptors); 1006 initial_map->set_instance_descriptors(*descriptors);
1007 initial_map->set_visitor_id(StaticVisitorBase::GetVisitorId(*initial_map)); 1007 initial_map->set_visitor_id(StaticVisitorBase::GetVisitorId(*initial_map));
1008 1008
1009 // RegExp prototype object is itself a RegExp. 1009 // RegExp prototype object is itself a RegExp.
1010 Handle<Map> proto_map = factory->CopyMapDropTransitions(initial_map); 1010 Handle<Map> proto_map = factory->CopyMapDropTransitions(initial_map);
1011 proto_map->set_prototype(global_context()->initial_object_prototype()); 1011 proto_map->set_prototype(global_context()->initial_object_prototype());
1012 Handle<JSObject> proto = factory->NewJSObjectFromMap(proto_map); 1012 Handle<JSObject> proto = factory->NewJSObjectFromMap(proto_map);
1013 proto->InObjectPropertyAtPut(JSRegExp::kSourceFieldIndex, 1013 proto->InObjectPropertyAtPut(JSRegExp::kSourceFieldIndex,
1014 heap->empty_string()); 1014 heap->query_colon_symbol());
1015 proto->InObjectPropertyAtPut(JSRegExp::kGlobalFieldIndex, 1015 proto->InObjectPropertyAtPut(JSRegExp::kGlobalFieldIndex,
1016 heap->false_value()); 1016 heap->false_value());
1017 proto->InObjectPropertyAtPut(JSRegExp::kIgnoreCaseFieldIndex, 1017 proto->InObjectPropertyAtPut(JSRegExp::kIgnoreCaseFieldIndex,
1018 heap->false_value()); 1018 heap->false_value());
1019 proto->InObjectPropertyAtPut(JSRegExp::kMultilineFieldIndex, 1019 proto->InObjectPropertyAtPut(JSRegExp::kMultilineFieldIndex,
1020 heap->false_value()); 1020 heap->false_value());
1021 proto->InObjectPropertyAtPut(JSRegExp::kLastIndexFieldIndex, 1021 proto->InObjectPropertyAtPut(JSRegExp::kLastIndexFieldIndex,
1022 Smi::FromInt(0), 1022 Smi::FromInt(0),
1023 SKIP_WRITE_BARRIER); // It's a Smi. 1023 SKIP_WRITE_BARRIER); // It's a Smi.
1024 initial_map->set_prototype(*proto); 1024 initial_map->set_prototype(*proto);
(...skipping 1343 matching lines...) Expand 10 before | Expand all | Expand 10 after
2368 return from + sizeof(NestingCounterType); 2368 return from + sizeof(NestingCounterType);
2369 } 2369 }
2370 2370
2371 2371
2372 // Called when the top-level V8 mutex is destroyed. 2372 // Called when the top-level V8 mutex is destroyed.
2373 void Bootstrapper::FreeThreadResources() { 2373 void Bootstrapper::FreeThreadResources() {
2374 ASSERT(!IsActive()); 2374 ASSERT(!IsActive());
2375 } 2375 }
2376 2376
2377 } } // namespace v8::internal 2377 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698