src/regexp.js - Issue 10134010: Fix source property of empty RegExp objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/regexp.js

Issue 10134010: Fix source property of empty RegExp objects. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comment by Andreas Rossberg. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/regexp.js

diff --git a/src/regexp.js b/src/regexp.js

index 7bcb612b5e0d3e2d8ac0b07812565dceb0ad4a48..a574f62bf6a040b808bc40ea380f8a497f2261fe 100644

--- a/src/regexp.js

+++ b/src/regexp.js

@@ -278,11 +278,7 @@ function TrimRegExp(regexp) {

function RegExpToString() {

- // If this.source is an empty string, output /(?:)/.

- // http://bugzilla.mozilla.org/show_bug.cgi?id=225550

- // ecma_2/RegExp/properties-001.js.

- var src = this.source ? this.source : '(?:)';

- var result = '/' + src + '/';

+ var result = '/' + this.source + '/';

if (this.global) result += 'g';

if (this.ignoreCase) result += 'i';

if (this.multiline) result += 'm';

« no previous file with comments | « src/heap.h ('k') | src/runtime.cc » ('j') | no next file with comments »