Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 9581016: It is the setter that can have a result, but not the StoreInstanceFieldNode. (Closed)

Created:
8 years, 9 months ago by srdjan
Modified:
8 years, 9 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

It is the setter that can have a result, but not the StoreInstanceFieldNode. Committed: https://code.google.com/p/dart/source/detail?r=4902

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M runtime/vm/code_generator_ia32.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/code_generator_x64.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/opt_code_generator_ia32.cc View 1 2 9 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
8 years, 9 months ago (2012-03-02 19:54:21 UTC) #1
regis
LGTM, but how about x64?
8 years, 9 months ago (2012-03-02 21:23:00 UTC) #2
srdjan
8 years, 9 months ago (2012-03-02 21:45:42 UTC) #3
On 2012/03/02 21:23:00, regis wrote:
> LGTM, but how about x64?

Ouch.. forgot it. Will add it there as well. Thanks.

Powered by Google App Engine
This is Rietveld 408576698