runtime/vm/code_generator_x64.cc - Issue 9581016: It is the setter that can have a result, but not the StoreInstanceFieldNode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_generator_x64.cc

Issue 9581016: It is the setter that can have a result, but not the StoreInstanceFieldNode. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/code_generator_x64.cc

===================================================================

--- runtime/vm/code_generator_x64.cc (revision 4900)

+++ runtime/vm/code_generator_x64.cc (working copy)

@@ -961,10 +961,7 @@

}

__ popq(R10); // Instance.

__ StoreIntoObject(R10, FieldAddress(R10, node->field().Offset()), RAX);

- if (IsResultNeeded(node)) {

- // The result is the input value.

- __ pushq(RAX);

- }

+ ASSERT(!IsResultNeeded(node));

}

« no previous file with comments | « runtime/vm/code_generator_ia32.cc ('k') | runtime/vm/opt_code_generator_ia32.cc » ('j') | no next file with comments »