Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: runtime/vm/code_generator_x64.cc

Issue 9581016: It is the setter that can have a result, but not the StoreInstanceFieldNode. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/code_generator_ia32.cc ('k') | runtime/vm/opt_code_generator_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/code_generator.h" 8 #include "vm/code_generator.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 943 matching lines...) Expand 10 before | Expand all | Expand 10 after
954 MarkDeoptPoint(node->id(), node->token_index()); 954 MarkDeoptPoint(node->id(), node->token_index());
955 __ popq(RAX); // Value. 955 __ popq(RAX); // Value.
956 if (FLAG_enable_type_checks) { 956 if (FLAG_enable_type_checks) {
957 GenerateAssertAssignable(node->id(), 957 GenerateAssertAssignable(node->id(),
958 node->value()->token_index(), 958 node->value()->token_index(),
959 AbstractType::ZoneHandle(node->field().type()), 959 AbstractType::ZoneHandle(node->field().type()),
960 String::ZoneHandle(node->field().name())); 960 String::ZoneHandle(node->field().name()));
961 } 961 }
962 __ popq(R10); // Instance. 962 __ popq(R10); // Instance.
963 __ StoreIntoObject(R10, FieldAddress(R10, node->field().Offset()), RAX); 963 __ StoreIntoObject(R10, FieldAddress(R10, node->field().Offset()), RAX);
964 if (IsResultNeeded(node)) { 964 ASSERT(!IsResultNeeded(node));
965 // The result is the input value.
966 __ pushq(RAX);
967 }
968 } 965 }
969 966
970 967
971 // Expects array and index on stack and returns result in RAX. 968 // Expects array and index on stack and returns result in RAX.
972 void CodeGenerator::GenerateLoadIndexed(intptr_t node_id, 969 void CodeGenerator::GenerateLoadIndexed(intptr_t node_id,
973 intptr_t token_index) { 970 intptr_t token_index) {
974 // Invoke the [] operator on the receiver object with the index as argument. 971 // Invoke the [] operator on the receiver object with the index as argument.
975 const String& operator_name = 972 const String& operator_name =
976 String::ZoneHandle(String::NewSymbol(Token::Str(Token::kINDEX))); 973 String::ZoneHandle(String::NewSymbol(Token::Str(Token::kINDEX)));
977 const int kNumArguments = 2; // Receiver and index. 974 const int kNumArguments = 2; // Receiver and index.
(...skipping 1729 matching lines...) Expand 10 before | Expand all | Expand 10 after
2707 const Error& error = Error::Handle( 2704 const Error& error = Error::Handle(
2708 Parser::FormatError(script, token_index, "Error", format, args)); 2705 Parser::FormatError(script, token_index, "Error", format, args));
2709 va_end(args); 2706 va_end(args);
2710 Isolate::Current()->long_jump_base()->Jump(1, error); 2707 Isolate::Current()->long_jump_base()->Jump(1, error);
2711 UNREACHABLE(); 2708 UNREACHABLE();
2712 } 2709 }
2713 2710
2714 } // namespace dart 2711 } // namespace dart
2715 2712
2716 #endif // defined TARGET_ARCH_X64 2713 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/code_generator_ia32.cc ('k') | runtime/vm/opt_code_generator_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698