Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: runtime/vm/opt_code_generator_ia32.cc

Issue 9581016: It is the setter that can have a result, but not the StoreInstanceFieldNode. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_generator_x64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/opt_code_generator_ia32.cc
===================================================================
--- runtime/vm/opt_code_generator_ia32.cc (revision 4900)
+++ runtime/vm/opt_code_generator_ia32.cc (working copy)
@@ -565,7 +565,7 @@
void OptimizingCodeGenerator::HandleResult(AstNode* node, Register result_reg) {
- if (CodeGenerator::IsResultNeeded(node)) {
+ if (IsResultNeeded(node)) {
if (IsResultInEaxRequested(node)) {
if (result_reg != EAX) {
__ movl(EAX, result_reg);
@@ -873,7 +873,7 @@
ASSERT(node->kind() == Token::kSUB);
__ DoubleNegate(XMM0);
__ movsd(FieldAddress(kResultRegister, Double::value_offset()), XMM0);
- if (CodeGenerator::IsResultNeeded(node)) {
+ if (IsResultNeeded(node)) {
if (node->info() != NULL) {
node->info()->set_is_temp(using_temp);
node->info()->set_is_class(&double_class_);
@@ -1246,7 +1246,7 @@
default: UNREACHABLE();
}
__ movsd(FieldAddress(result_register, Double::value_offset()), XMM0);
- if (CodeGenerator::IsResultNeeded(node)) {
+ if (IsResultNeeded(node)) {
if (node->info() != NULL) {
node->info()->set_is_temp(using_temp);
node->info()->set_is_class(&double_class_);
@@ -2006,7 +2006,7 @@
CodeGenInfo left_info(node->left());
CodeGenInfo right_info(node->right());
VisitLoadTwo(node->left(), node->right(), EAX, EDX);
- if (!CodeGenerator::IsResultNeeded(node)) {
+ if (!IsResultNeeded(node)) {
return;
}
const Immediate raw_null =
@@ -2099,7 +2099,7 @@
CodeGenInfo left_info(node->left());
CodeGenInfo right_info(node->right());
VisitLoadTwo(node->left(), node->right(), EAX, EDX);
- if (!CodeGenerator::IsResultNeeded(node)) {
+ if (!IsResultNeeded(node)) {
return true;
}
if (left_info.IsClass(smi_class_) && right_info.IsClass(smi_class_)) {
@@ -2205,7 +2205,7 @@
// All targets are Object.==, i.e., '==='. Smi is not among the classes.
VisitLoadTwo(node->left(), node->right(), EAX, EDX);
- if (!CodeGenerator::IsResultNeeded(node)) {
+ if (!IsResultNeeded(node)) {
return true;
}
Label compare;
@@ -2299,12 +2299,12 @@
__ j(PARITY_EVEN, &is_false, Assembler::kNearJump); // NaN -> false;
__ j(true_condition, &is_true, Assembler::kNearJump);
__ Bind(&is_false);
- if (CodeGenerator::IsResultNeeded(node)) {
+ if (IsResultNeeded(node)) {
__ PushObject(bool_false);
}
__ jmp(&done);
__ Bind(&is_true);
- if (CodeGenerator::IsResultNeeded(node)) {
+ if (IsResultNeeded(node)) {
__ PushObject(bool_true);
}
__ Bind(&done);
@@ -2328,7 +2328,7 @@
VisitLoadTwo(node->left(), node->right(), EAX, EDX);
__ cmpl(EAX, EDX);
}
- if (!CodeGenerator::IsResultNeeded(node)) {
+ if (!IsResultNeeded(node)) {
return;
}
Condition condition = node->kind() == Token::kEQ_STRICT ? EQUAL : NOT_EQUAL;
@@ -3097,8 +3097,7 @@
}
VisitLoadTwo(node->instance(), node->value(), EDX, EAX);
__ StoreIntoObject(EDX, FieldAddress(EDX, node->field().Offset()), EAX);
- // The result is the input value.
- HandleResult(node, EAX);
+ ASSERT(!IsResultNeeded(node));
}
« no previous file with comments | « runtime/vm/code_generator_x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698