Issue 9346021: Turn off code generation in dartc by default, soon to be static analysis only

Issue 9346021: Turn off code generation in dartc by default, soon to be static analysis only (Closed)

Created:
8 years, 10 months ago by zundel

Modified:
8 years, 10 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org, ahe, danrubel, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

This change makes the normal way of running dartc equivalent to running it with what was the --check-only flag. Shared test status files have been updated to run 'green' for now until we can get a special static analysis testing tool in place. The code generation backend is still there behind a flag, but due to be removed. Committed: https://code.google.com/p/dart/source/detail?r=4008

Patch Set 1 : Cosmetic changes #

Total comments: 4

Patch Set 2 : Feedback from scheglov #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+391 lines, -56 lines)			Patch
M	compiler/java/com/google/dart/compiler/CommandLineOptions.java	View	1	4 chunks	+10 lines, -9 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/DartCompiler.java	View		1 chunk	+16 lines, -14 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/backend/js/JsBackendTests.java	View	1	2 chunks	+1 line, -17 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/common/CommonTests.java	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/End2EndTestCase.java	View		4 chunks	+30 lines, -4 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java	View	1	3 chunks	+11 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationTest.java	View	1	4 chunks	+12 lines, -2 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationWithPrefixTest.java	View	1	2 chunks	+10 lines, -1 line	0 comments	Download
M	tests/co19/co19-compiler.status	View		1 chunk	+228 lines, -0 lines	0 comments	Download
M	tests/corelib/corelib.status	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	tests/isolate/isolate.status	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1	3 chunks	+67 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

lgtm http://codereview.chromium.org/9346021/diff/5001/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationWithPrefixTest.java File compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationWithPrefixTest.java (right): http://codereview.chromium.org/9346021/diff/5001/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationWithPrefixTest.java#newcode68 compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationWithPrefixTest.java:68: CompilerOptions compilerOptions = new CompilerOptions() { I like ...

8 years, 10 months ago (2012-02-07 21:38:54 UTC) #2

zundel

8 years, 10 months ago (2012-02-07 22:02:00 UTC) #3

Committed as r4008

http://codereview.chromium.org/9346021/diff/5001/compiler/javatests/com/googl...
File
compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationWithPrefixTest.java
(right):

http://codereview.chromium.org/9346021/diff/5001/compiler/javatests/com/googl...
compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationWithPrefixTest.java:68:
CompilerOptions compilerOptions = new CompilerOptions() {
On 2012/02/07 21:38:54, scheglov wrote:
> I like this comment in other tests.
> // TODO(zundel): Update these tests to run without requiring code generation

Done.

http://codereview.chromium.org/9346021/diff/5001/tests/isolate/isolate.status
File tests/isolate/isolate.status (right):

http://codereview.chromium.org/9346021/diff/5001/tests/isolate/isolate.status...
tests/isolate/isolate.status:15: Isolate2NegativeTest: Fail   # static change
with --check-only
On 2012/02/07 21:38:54, scheglov wrote:
> "static change" or "status change"?

Oops, I thought I got all those.
Done.

Expand Messages | Collapse Messages