Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationTest.java

Issue 9346021: Turn off code generation in dartc by default, soon to be static analysis only (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Feedback from scheglov Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationTest.java b/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationTest.java
index 457cae7c2c76e657bf9b0dbea49330a509a76cea..54f3d094462114a59f817e322b9ea79143e45f63 100644
--- a/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationTest.java
+++ b/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilationTest.java
@@ -9,6 +9,7 @@ import static com.google.dart.compiler.backend.js.AbstractJsBackend.EXTENSION_AP
import static com.google.dart.compiler.backend.js.AbstractJsBackend.EXTENSION_JS;
import com.google.common.collect.Lists;
+import com.google.dart.compiler.CommandLineOptions.CompilerOptions;
import com.google.dart.compiler.CompilerTestCase;
import com.google.dart.compiler.DartCompilationError;
import com.google.dart.compiler.DartCompiler;
@@ -29,6 +30,7 @@ import java.util.List;
import java.util.Set;
import java.util.concurrent.ConcurrentSkipListSet;
+// TODO(zundel): update this test not to rely on code generation
public class IncrementalCompilationTest extends CompilerTestCase {
private static final String TEST_BASE_PATH = "com/google/dart/compiler/end2end/inc/";
@@ -67,7 +69,15 @@ public class IncrementalCompilationTest extends CompilerTestCase {
@Override
protected void setUp() throws Exception {
- config = new DefaultCompilerConfiguration(new JavascriptBackend()) {
+ CompilerOptions compilerOptions = new CompilerOptions() {
+ // TODO(zundel): Update these tests to run without requiring code generation
+ @Override
+ public boolean checkOnly() {
+ return false;
+ }
+ };
+ config = new DefaultCompilerConfiguration(new JavascriptBackend(),
+ compilerOptions) {
@Override
public boolean incremental() {
return true;
@@ -175,7 +185,7 @@ public class IncrementalCompilationTest extends CompilerTestCase {
compile();
// Test against normalization having an effect on hashcodes
- // SomeInterface2 is an empty interface that can have an extra default constructor added by
+ // SomeInterface2 is an empty interface that can have an extra default constructor added by
// the dartc backend normalization process. By depending on a class that implements the interface,
// my.app.dart.deps will transitively depend on the empty interface. If something changes
// with how hashcodes are generated, this test should be updated.

Powered by Google App Engine
This is Rietveld 408576698