Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: compiler/java/com/google/dart/compiler/CommandLineOptions.java

Issue 9346021: Turn off code generation in dartc by default, soon to be static analysis only (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Feedback from scheglov Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/DartCompiler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/CommandLineOptions.java
diff --git a/compiler/java/com/google/dart/compiler/CommandLineOptions.java b/compiler/java/com/google/dart/compiler/CommandLineOptions.java
index 9afea27b3133a7721116a14da185816023ffcd77..9edc2a728070aa43c418da0030d97cc8420ee58c 100644
--- a/compiler/java/com/google/dart/compiler/CommandLineOptions.java
+++ b/compiler/java/com/google/dart/compiler/CommandLineOptions.java
@@ -35,9 +35,9 @@ public class CommandLineOptions {
usage = "Batch mode (for unit testing)")
private boolean batch = false;
- @Option(name = "--check-only", aliases = { "-check-only" },
- usage = "Do not generate output, only analyze")
- private boolean checkOnly = false;
+ @Option(name = "--deprecated-generate-code",
+ usage = "Use deprecated code generation.\n Will be removed 1 March 2012.")
+ private boolean deprecatedGenerateCode = false;
@Option(name = "--expose_core_impl", usage = "Automatic import of dart:coreimpl library")
private boolean exposeCoreImpl = false;
@@ -61,13 +61,13 @@ public class CommandLineOptions {
@Option(name = "--generate_source_maps",
usage = "Generate source maps")
private boolean generateSourceMaps = false;
-
+
@Option(name = "--dump_ast_format",
usage = "Dump parse tree. Supported formats include console, text or dot")
private String dumpAST = "";
-
+
@Option(name = "--coverage_type",
- usage = "Add instrumentation probes for collecting coverage. " +
+ usage = "Add instrumentation probes for collecting coverage. " +
"Supported types include function, statement, branch and all")
private String coverage = "";
@@ -150,7 +150,8 @@ public class CommandLineOptions {
* Returns whether the option -check-only is provided.
*/
public boolean checkOnly() {
- return checkOnly;
+ return !deprecatedGenerateCode &&
+ getIsolateStubClasses().isEmpty();
}
/**
@@ -222,11 +223,11 @@ public class CommandLineOptions {
public boolean generateHumanReadableOutput() {
return generateHumanReadableOutput;
}
-
+
public String dumpAST(){
return dumpAST;
}
-
+
public String getCoverageType(){
return coverage;
}
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/DartCompiler.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698