Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Unified Diff: compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java

Issue 9346021: Turn off code generation in dartc by default, soon to be static analysis only (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Feedback from scheglov Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
diff --git a/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java b/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
index 3ea5e90495bfc30b687a1f1c4c50617cd4225628..79726755897f3e0b0d8b2ba05023ffd4015d6b61 100644
--- a/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
+++ b/compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
@@ -10,6 +10,7 @@ import static com.google.dart.compiler.common.ErrorExpectation.assertErrors;
import static com.google.dart.compiler.common.ErrorExpectation.errEx;
import com.google.common.collect.Lists;
+import com.google.dart.compiler.CommandLineOptions.CompilerOptions;
import com.google.dart.compiler.CompilerTestCase;
import com.google.dart.compiler.DartCompilationError;
import com.google.dart.compiler.DartCompiler;
@@ -32,6 +33,7 @@ import java.util.List;
import java.util.Set;
import java.util.concurrent.ConcurrentSkipListSet;
+// TODO(zundel): update this test not to rely on code generation
public class IncrementalCompilation2Test extends CompilerTestCase {
private static final String APP = "Application.dart";
@@ -72,7 +74,15 @@ public class IncrementalCompilation2Test extends CompilerTestCase {
@Override
protected void setUp() throws Exception {
- config = new DefaultCompilerConfiguration(new JavascriptBackend()) {
+ CompilerOptions compilerOptions = new CompilerOptions() {
+ // TODO(zundel): Update these tests to run without requiring code generation
+ @Override
+ public boolean checkOnly() {
+ return false;
+ }
+ };
+ config = new DefaultCompilerConfiguration(new JavascriptBackend(),
+ compilerOptions) {
@Override
public boolean incremental() {
return true;

Powered by Google App Engine
This is Rietveld 408576698