Issue 10933043: Use ICData to collect type feedback on instance setter value. If value is always Smi, insert a smi …

Issue 10933043: Use ICData to collect type feedback on instance setter value. If value is always Smi, insert a smi … (Closed)

Created:
8 years, 3 months ago by srdjan

Modified:
8 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Use ICData to collect type feedback on instance setter value. If value is always Smi, insert a smi check and eliminate the store barrier. TODO: Implement it for indexed store (collecting three arguments). Committed: https://code.google.com/p/dart/source/detail?r=12257

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -13 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	1 2	3 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	4 chunks	+30 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2	3 chunks	+9 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://chromiumcodereview.appspot.com/10933043/diff/3002/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://chromiumcodereview.appspot.com/10933043/diff/3002/runtime/vm/intermediate_language.h#newcode2161 runtime/vm/intermediate_language.h:2161: : field_(field), may_need_store_barrier_(true) { Is there any reason ...

8 years, 3 months ago (2012-09-12 10:43:43 UTC) #2

srdjan

8 years, 3 months ago (2012-09-12 10:52:52 UTC) #3

https://chromiumcodereview.appspot.com/10933043/diff/3002/runtime/vm/intermed...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10933043/diff/3002/runtime/vm/intermed...
runtime/vm/intermediate_language.h:2161: : field_(field),
may_need_store_barrier_(true) {
On 2012/09/12 10:43:43, Vyacheslav Egorov (Google) wrote:
> Is there any reason for not passing it as a parameter to the constructor (and
> making it const field?)

Changed as suggested.

https://chromiumcodereview.appspot.com/10933043/diff/3002/runtime/vm/intermed...
runtime/vm/intermediate_language.h:2189: bool may_need_store_barrier_;
On 2012/09/12 10:43:43, Vyacheslav Egorov (Google) wrote:
> I would call it emit_store_barrier_

Done.

Expand Messages | Collapse Messages