Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: runtime/vm/intermediate_language.h

Issue 10933043: Use ICData to collect type feedback on instance setter value. If value is always Smi, insert a smi … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 12253)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -2157,8 +2157,11 @@
class StoreInstanceFieldInstr : public TemplateDefinition<2> {
public:
- StoreInstanceFieldInstr(const Field& field, Value* instance, Value* value)
- : field_(field) {
+ StoreInstanceFieldInstr(const Field& field,
+ Value* instance,
+ Value* value,
+ bool emit_store_barrier)
+ : field_(field), emit_store_barrier_(emit_store_barrier) {
ASSERT(instance != NULL);
ASSERT(value != NULL);
inputs_[0] = instance;
@@ -2172,6 +2175,9 @@
Value* instance() const { return inputs_[0]; }
Value* value() const { return inputs_[1]; }
+ bool emit_store_barrier() const {
+ return emit_store_barrier_;
+ }
virtual void PrintOperandsTo(BufferFormatter* f) const;
@@ -2180,6 +2186,7 @@
private:
const Field& field_;
+ const bool emit_store_barrier_;
DISALLOW_COPY_AND_ASSIGN(StoreInstanceFieldInstr);
};
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698