Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Side by Side Diff: runtime/vm/intermediate_language_ia32.cc

Issue 10933043: Use ICData to collect type feedback on instance setter value. If value is always Smi, insert a smi … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 931 matching lines...) Expand 10 before | Expand all | Expand 10 after
942 summary->set_in(1, 942 summary->set_in(1,
943 value()->NeedsStoreBuffer() ? Location::WritableRegister() 943 value()->NeedsStoreBuffer() ? Location::WritableRegister()
944 : Location::RequiresRegister()); 944 : Location::RequiresRegister());
945 return summary; 945 return summary;
946 } 946 }
947 947
948 948
949 void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 949 void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
950 Register instance_reg = locs()->in(0).reg(); 950 Register instance_reg = locs()->in(0).reg();
951 Register value_reg = locs()->in(1).reg(); 951 Register value_reg = locs()->in(1).reg();
952 if (this->value()->NeedsStoreBuffer()) { 952 if (this->value()->NeedsStoreBuffer() && emit_store_barrier()) {
953 __ StoreIntoObject(instance_reg, 953 __ StoreIntoObject(instance_reg,
954 FieldAddress(instance_reg, field().Offset()), value_reg); 954 FieldAddress(instance_reg, field().Offset()), value_reg);
955 } else { 955 } else {
956 __ StoreIntoObjectNoBarrier(instance_reg, 956 __ StoreIntoObjectNoBarrier(instance_reg,
957 FieldAddress(instance_reg, field().Offset()), value_reg); 957 FieldAddress(instance_reg, field().Offset()), value_reg);
958 } 958 }
959 } 959 }
960 960
961 961
962 LocationSummary* LoadStaticFieldInstr::MakeLocationSummary() const { 962 LocationSummary* LoadStaticFieldInstr::MakeLocationSummary() const {
(...skipping 1284 matching lines...) Expand 10 before | Expand all | Expand 10 after
2247 __ j(ABOVE_EQUAL, deopt); 2247 __ j(ABOVE_EQUAL, deopt);
2248 } 2248 }
2249 } 2249 }
2250 2250
2251 2251
2252 } // namespace dart 2252 } // namespace dart
2253 2253
2254 #undef __ 2254 #undef __
2255 2255
2256 #endif // defined TARGET_ARCH_X64 2256 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698