Use ICData to collect type feedback on instance setter value. If value is always Smi, insert a smi …

runtime/vm/intermediate_language.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_INTERMEDIATE_LANGUAGE_H_
 #define VM_INTERMEDIATE_LANGUAGE_H_
 
 #include "vm/allocation.h"
 #include "vm/ast.h"
 #include "vm/growable_array.h"
@@ skipping 2137 matching lines @@
 
  private:
   const Field& field_;
 
   DISALLOW_COPY_AND_ASSIGN(LoadInstanceFieldInstr);
 };
 
 
 class StoreInstanceFieldInstr : public TemplateDefinition<2> {
  public:
-  StoreInstanceFieldInstr(const Field& field, Value* instance, Value* value)
-      : field_(field) {
+  StoreInstanceFieldInstr(const Field& field,
+                          Value* instance,
+                          Value* value)
+      : field_(field), may_need_store_barrier_(true) {

[Vyacheslav Egorov (Google), 2012/09/12 10:43:43]

Is there any reason for not passing it as a parameter to the constructor (and
making it const field?)

[srdjan, 2012/09/12 10:52:52]

Changed as suggested.

     ASSERT(instance != NULL);
     ASSERT(value != NULL);
     inputs_[0] = instance;
     inputs_[1] = value;
   }
 
   DECLARE_INSTRUCTION(StoreInstanceField)
   virtual RawAbstractType* CompileType() const;
 
   const Field& field() const { return field_; }
 
   Value* instance() const { return inputs_[0]; }
   Value* value() const { return inputs_[1]; }
+  bool may_need_store_barrier() const {
+    return may_need_store_barrier_;
+  }
+  void set_may_need_store_barrier(bool value) {
+    may_need_store_barrier_ = value;
+  }
 
   virtual void PrintOperandsTo(BufferFormatter* f) const;
 
   virtual bool CanDeoptimize() const { return false; }
   virtual intptr_t ResultCid() const { return kDynamicCid; }
 
  private:
   const Field& field_;
+  bool may_need_store_barrier_;

[Vyacheslav Egorov (Google), 2012/09/12 10:43:43]

I would call it emit_store_barrier_

[srdjan, 2012/09/12 10:52:52]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(StoreInstanceFieldInstr);
 };
 
 
 class LoadStaticFieldInstr : public TemplateDefinition<0> {
  public:
   explicit LoadStaticFieldInstr(const Field& field) : field_(field) {}
 
   DECLARE_INSTRUCTION(LoadStaticField);
@@ skipping 1257 matching lines @@
   ForwardInstructionIterator* current_iterator_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(FlowGraphVisitor);
 };
 
 
 }  // namespace dart
 
 #endif  // VM_INTERMEDIATE_LANGUAGE_H_