Move print to corelib.

Move print to corelib.

Allow embedder customization in the VM through a static field that can
be set by the embedder.

Mark failing test that is unrelated to this change. The VM does not
like when you import dart:core explicitly and tells you there both
'dart:core' and 'dart:core' define 'print'.

R=ajohnsen@google.com,iposva@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=11603

[Anders Johnsen, 2012-08-29 12:39:20]

Waw, this is so much better! LGTM!

https://chromiumcodereview.appspot.com/10887024/diff/1/runtime/lib/print_patc...
File runtime/lib/print_patch.dart (right):

https://chromiumcodereview.appspot.com/10887024/diff/1/runtime/lib/print_patc...
runtime/lib/print_patch.dart:17: static _PrintClosure _printClosure = _print;
Very clean, nice!

[Ivan Posva, 2012-08-30 00:32:13]

Ideally you could move the initialization of the closure into the embedder and
the actual printing closure into the standalone builtin library. But if you need
this change to make forward progress now, then please file a bug against
yourself to clean this up later.

-Ivan

https://chromiumcodereview.appspot.com/10887024/diff/3001/corelib/src/print.dart
File corelib/src/print.dart (right):

https://chromiumcodereview.appspot.com/10887024/diff/3001/corelib/src/print.d...
corelib/src/print.dart:5: void print(Object object) {
This change makes no sense to me.

Why was #library("nativewrappers") in this file before?

https://chromiumcodereview.appspot.com/10887024/diff/3001/runtime/lib/print.cc
File runtime/lib/print.cc (right):

https://chromiumcodereview.appspot.com/10887024/diff/3001/runtime/lib/print.c...
runtime/lib/print.cc:5: #include "vm/bootstrap_natives.h"
Again this change file makes no sense to me.

https://chromiumcodereview.appspot.com/10887024/diff/3001/runtime/lib/print.c...
runtime/lib/print.cc:10: GET_NATIVE_ARGUMENT(String, str, arguments->At(0));
The core VM is not allowed to write to stdout. This is the job of the embedder
and thus should go somewhere else.

https://chromiumcodereview.appspot.com/10887024/diff/3001/runtime/lib/print.c...
runtime/lib/print.cc:13: fputc('\n', stdout);
By having two calls you will be hit with concurrent prints messing with your
line ending addition. What is wrong with fprintf(stdout, "%s\n", cstring)?

https://chromiumcodereview.appspot.com/10887024/diff/3001/runtime/lib/print_p...
File runtime/lib/print_patch.dart (right):

https://chromiumcodereview.appspot.com/10887024/diff/3001/runtime/lib/print_p...
runtime/lib/print_patch.dart:13: static void _print(Object obj) native
"PrintImplementation_printString";
This closure belongs into the builtin library.

https://chromiumcodereview.appspot.com/10887024/diff/3001/runtime/lib/print_p...
runtime/lib/print_patch.dart:17: static _PrintClosure _printClosure = _print;
And we should initialize the _printClosure with something like this:
static void _unsupported(Object obj) { throw new UnsupportedException(); }

[Mads Ager (google), 2012-08-30 06:59:17]

Ivan, could you take a quick look. Used patching instead to avoid printing to
stdout from the VM library.

https://chromiumcodereview.appspot.com/10887024/diff/3001/corelib/src/print.dart
File corelib/src/print.dart (right):

https://chromiumcodereview.appspot.com/10887024/diff/3001/corelib/src/print.d...
corelib/src/print.dart:5: void print(Object object) {
On 2012/08/30 00:32:13, Ivan Posva wrote:
> This change makes no sense to me.
> 
> Why was #library("nativewrappers") in this file before?

It wasn't. It is the diff tools playing with us. This is a new file.

https://chromiumcodereview.appspot.com/10887024/diff/3001/runtime/lib/print.cc
File runtime/lib/print.cc (right):

https://chromiumcodereview.appspot.com/10887024/diff/3001/runtime/lib/print.c...
runtime/lib/print.cc:5: #include "vm/bootstrap_natives.h"
On 2012/08/30 00:32:13, Ivan Posva wrote:
> Again this change file makes no sense to me.

Diff tools playing with the change. New file.

https://chromiumcodereview.appspot.com/10887024/diff/3001/runtime/lib/print.c...
runtime/lib/print.cc:10: GET_NATIVE_ARGUMENT(String, str, arguments->At(0));
On 2012/08/30 00:32:13, Ivan Posva wrote:
> The core VM is not allowed to write to stdout. This is the job of the embedder
> and thus should go somewhere else.

That makes sense. I'll move this back to builtins and patch it in as in Dartium.

https://chromiumcodereview.appspot.com/10887024/diff/3001/runtime/lib/print.c...
runtime/lib/print.cc:13: fputc('\n', stdout);
On 2012/08/30 00:32:13, Ivan Posva wrote:
> By having two calls you will be hit with concurrent prints messing with your
> line ending addition. What is wrong with fprintf(stdout, "%s\n", cstring)?

Nothing wrong with that. I was following what was in builtin. I have reinstated
the builtin code.

https://chromiumcodereview.appspot.com/10887024/diff/3001/runtime/lib/print_p...
File runtime/lib/print_patch.dart (right):

https://chromiumcodereview.appspot.com/10887024/diff/3001/runtime/lib/print_p...
runtime/lib/print_patch.dart:13: static void _print(Object obj) native
"PrintImplementation_printString";
On 2012/08/30 00:32:13, Ivan Posva wrote:
> This closure belongs into the builtin library.

Got it. I can move it back to builtin and do the patching through the API from
there.

https://chromiumcodereview.appspot.com/10887024/diff/3001/runtime/lib/print_p...
runtime/lib/print_patch.dart:17: static _PrintClosure _printClosure = _print;
On 2012/08/30 00:32:13, Ivan Posva wrote:
> And we should initialize the _printClosure with something like this:
> static void _unsupported(Object obj) { throw new UnsupportedException(); }

We can do that. I actually liked the fact that embedders got print wired up to
stdout out of the box and could overwrite it. But I do understand your point
that the VM library should not write to stdout.

[Ivan Posva, 2012-08-30 07:06:52]

LGTM -ip

https://chromiumcodereview.appspot.com/10887024/diff/9001/lib/compiler/implem...
File lib/compiler/implementation/lib/coreimpl_patch.dart (right):

https://chromiumcodereview.appspot.com/10887024/diff/9001/lib/compiler/implem...
lib/compiler/implementation/lib/coreimpl_patch.dart:5: // Patch file for
dart:core classes.
coreimpl

[Mads Ager (google), 2012-08-30 07:08:28]

https://chromiumcodereview.appspot.com/10887024/diff/9001/lib/compiler/implem...
File lib/compiler/implementation/lib/coreimpl_patch.dart (right):

https://chromiumcodereview.appspot.com/10887024/diff/9001/lib/compiler/implem...
lib/compiler/implementation/lib/coreimpl_patch.dart:5: // Patch file for
dart:core classes.
On 2012/08/30 07:06:52, Ivan Posva wrote:
> coreimpl

Good catch. Thanks!