Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: runtime/bin/builtin.cc

Issue 10887024: Move print to corelib. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comment. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/lib/coreimpl_patch.dart ('k') | runtime/bin/builtin.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/builtin.cc
diff --git a/runtime/bin/builtin.cc b/runtime/bin/builtin.cc
index 9ba9053a9352f649d0695a910d389369c012b40e..c95a88a87d156d424818566578cc4d3e6dc12727 100644
--- a/runtime/bin/builtin.cc
+++ b/runtime/bin/builtin.cc
@@ -22,15 +22,6 @@ Builtin::builtin_lib_props Builtin::builtin_libraries_[] = {
};
-static void ImportBuiltinLibIntoLib(
- const char* liburl, Dart_Handle builtin_lib) {
- Dart_Handle url = Dart_NewString(liburl);
- Dart_Handle lib = Dart_LookupLibrary(url);
- DART_CHECK_VALID(lib);
- DART_CHECK_VALID(Dart_LibraryImportLibrary(lib, builtin_lib, Dart_Null()));
-}
-
-
Dart_Handle Builtin::Source(BuiltinLibraryId id) {
ASSERT((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) ==
kInvalidLibrary);
@@ -47,12 +38,6 @@ void Builtin::SetupLibrary(Dart_Handle library, BuiltinLibraryId id) {
// Setup the native resolver for built in library functions.
DART_CHECK_VALID(Dart_SetNativeResolver(library, NativeLookup));
}
- if (id == kBuiltinLibrary) {
- // Import the builtin library into the core and isolate libraries.
- ImportBuiltinLibIntoLib(DartUtils::kCoreLibURL, library);
- ImportBuiltinLibIntoLib(DartUtils::kCoreImplLibURL, library);
- ImportBuiltinLibIntoLib(DartUtils::kIsolateLibURL, library);
- }
}
« no previous file with comments | « lib/compiler/implementation/lib/coreimpl_patch.dart ('k') | runtime/bin/builtin.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698